Merge pull request #1 from dotnet/master

a

Author: Johnny Pham

.dockerignore

@@ -0,0 +1,25 @@
+**/.classpath
+**/.dockerignore
+**/.env
+**/.git
+**/.gitignore
+**/.project
+**/.settings
+**/.toolstarget
+**/.vs
+**/.vscode
+**/*.*proj.user
+**/*.dbmdl
+**/*.jfm
+**/azds.yaml
+**/bin
+**/charts
+**/docker-compose*
+**/Dockerfile*
+**/node_modules
+**/npm-debug.log
+**/obj
+**/secrets.dev.yaml
+**/values.dev.yaml
+LICENSE
+README.md

BUILDGUIDE.md

@@ -177,10 +177,41 @@ Tests can be built and run with custom Target Frameworks. See the below examples
 
 Managed SNI can be enabled on Windows by enabling the below AppContext switch:
 
-**"Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows"**
+**"Switch.Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows"**
 
 ## Set truncation on for scaled decimal parameters
 
 Scaled decimal parameter truncation can be enabled by enabling the below AppContext switch:
 
 **"Switch.Microsoft.Data.SqlClient.TruncateScaledDecimal"**
+
+## Debugging SqlClient on Linux from Windows
+
+For enhanced developer experience, we support debugging SqlClient on Linux from Windows, using the project "**Microsoft.Data.SqlClient.DockerLinuxTest**" that requires "Container Tools" to be enabled in Visual Studio. You may import configuration: [VS19Components.vsconfig](./tools/vsconfig/VS19Components.vsconfig) if not enabled already.
+
+This project is also included in `docker-compose.yml` to demonstrate connectivity with SQL Server docker image.
+
+To run the same:
+1. Build the Solution in Visual Studio
+2. Set  `docker-compose` as Startup Project
+3. Run "Docker-Compose" launch configuration.
+4. You will see similar message in Debug window:
+    ```log
+    Connected to SQL Server v15.00.4023 from Unix 4.19.76.0
+    The program 'dotnet' has exited with code 0 (0x0).
+    ```
+5. Now you can write code in [Program.cs](/src/Microsoft.Data.SqlClient/tests/DockerLinuxTest/Program.cs) to debug SqlClient on Linux!
+
+### Troubleshooting Docker issues
+
+There may be times where connection cannot be made to SQL Server, we found below ideas helpful:
+
+- Clear Docker images to create clean image from time-to-time, and clear docker cache if needed by running `docker system prune` in Command Prompt.
+
+- If you face `sni.dll not found` errors when debugging, try updating below properties in netcore\Microsoft.Data.SqlClient.csproj file and try again:
+  ```xml
+    <OSGroup>Unix</OSGroup>
+    <TargetsWindows>false</TargetsWindows>
+    <TargetsUnix>true</TargetsUnix>
+  ```
+  ```

CHANGELOG.md

@@ -4,6 +4,30 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
+## [Preview Release 2.0.0-preview3.20122.2] - 2020-05-01
+
+### Added
+- Allow passing username with Active Directory Interactive Authentication in .NET Framework [#492](https://github.com/dotnet/SqlClient/pull/492)
+- Allow large UDT buffers for .NET Framework [#456](https://github.com/dotnet/SqlClient/pull/456) 
+- Added "Transaction Id" and "Client Version" in Diagnostic Source traces [#515](https://github.com/dotnet/SqlClient/pull/515)
+- Added new `SqlConnectionOverrides` APIs to perform `SqlConnection.Open()` with fail fast option [#463](https://github.com/dotnet/SqlClient/pull/463)
+
+### Fixed
+- Addressed MARS TDS Header errors by reverting changes to make `SqlDataReader.ReadAsync()` non-blocking [#547](https://github.com/dotnet/SqlClient/pull/547)
+- Fixed driver behavior to not perform enlistment of pooled connection in aborted transaction [#543](https://github.com/dotnet/SqlClient/pull/543)
+- Fixed wrong application domain selected when starting `SqlDependencyListener` [#410](https://github.com/dotnet/SqlClient/pull/410)
+- Added missing refs for `RowCopied` property in `SqlBulkCopy` [#508](https://github.com/dotnet/SqlClient/pull/508)
+
+### Changes
+- Improved performance by removing unwanted method calls in Event Source tracing [#506](https://github.com/dotnet/SqlClient/pull/506)
+- Removed Diagnostic Source and Configuration Manager dependencies from .NET Standard implementation [#535](https://github.com/dotnet/SqlClient/pull/535)
+- Removed redundant calls to `DbConnectionPoolKey.GetType()` [#512](https://github.com/dotnet/SqlClient/pull/512)
+
+### Breaking Changes
+- Updated driver to perform decimal scale rounding to match SQL Server behavior [#470](https://github.com/dotnet/SqlClient/pull/470)
+- Standardized App Context switch name that enables Managed SNI on Windows for .NET Core and .NET Standard (break only applies to 2.0 preview releases that introduced the switch) [#548](https://github.com/dotnet/SqlClient/pull/548)
+
+
 ## [Stable Release 1.1.2] - 2020-04-15
 
 ### Added

doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml

@@ -928,6 +928,46 @@ GO
  The <see langword="&lt;system.data.localdb&gt;" /> tag in the app.config file has invalid or unknown elements.</exception>
             <exception cref="T:System.Configuration.ConfigurationErrorsException">There are two entries with the same name in the <see langword="&lt;localdbinstances&gt;" /> section.</exception>
         </Open>
+        <OpenWithOverrides>
+            <param name="overrides">Options to override default connection open behavior.</param>
+            <summary>
+                Opens a database connection with the property settings specified by the <see cref="P:Microsoft.Data.SqlClient.SqlConnection.ConnectionString" />.
+            </summary>
+            <remarks>
+            <format type="text/markdown">
+                <![CDATA[
+
+## Remarks
+ The <xref:Microsoft.Data.SqlClient.SqlConnection> draws an open connection from the connection pool if one is available. Otherwise, it establishes a new connection to an instance of SQL Server. If overrides are specified, the first open attempt will apply the specified overrides to the open action.
+
+> [!NOTE]
+>  If the <xref:Microsoft.Data.SqlClient.SqlConnection> goes out of scope, it is not closed. Therefore, you must explicitly close the connection by calling <xref:Microsoft.Data.SqlClient.SqlConnection.Close%2A>.
+
+> [!NOTE]
+>  If you specify a port number other than 1433 when you are trying to connect to an instance of SQL Server and using a protocol other than TCP/IP, the <xref:Microsoft.Data.SqlClient.SqlConnection.Open%2A> method fails. To specify a port number other than 1433, include "server=machinename,port number" in the connection string, and use the TCP/IP protocol.
+
+> [!NOTE]
+>  The .NET Framework Data Provider for SQL Server requires the Security permission with "Allows calls to unmanaged assemblies" enabled (<xref:System.Security.Permissions.SecurityPermission> with <xref:System.Security.Permissions.SecurityPermissionFlag> set to `UnmanagedCode`) to open a <xref:Microsoft.Data.SqlClient.SqlConnection> with SQL Debugging enabled.
+
+## Examples
+ The following example creates a <xref:Microsoft.Data.SqlClient.SqlConnection>, opens it, and displays some of its properties. The connection is automatically closed at the end of the `using` block.
+
+ [!code-csharp[SqlConnection_Open Example#1](~/../sqlclient/doc/samples/SqlConnection_Open.cs#1)]
+
+]]>
+            </format>
+            </remarks>
+            <exception cref="T:System.InvalidOperationException">Cannot open a connection without specifying a data source or server.
+
+ or
+
+ The connection is already open.
+            </exception>
+            <exception cref="T:Microsoft.Data.SqlClient.SqlException">A connection-level error occurred while opening the connection. If the <see cref="P:Microsoft.Data.SqlClient.SqlException.Number" /> property contains the value 18487 or 18488, this indicates that the specified password has expired or must be reset. See the <see cref="M:Microsoft.Data.SqlClient.SqlConnection.ChangePassword(System.String,System.String)" /> method for more information.
+
+ The <see langword="&lt;system.data.localdb&gt;" /> tag in the app.config file has invalid or unknown elements.</exception>
+            <exception cref="T:System.Configuration.ConfigurationErrorsException">There are two entries with the same name in the <see langword="&lt;localdbinstances&gt;" /> section.</exception>
+        </OpenWithOverrides>
         <OpenAsync>
             <param name="cancellationToken">The cancellation instruction.</param>
             <summary>An asynchronous version of <see cref="M:Microsoft.Data.SqlClient.SqlConnection.Open" />, which opens a database connection with the property settings specified by the <see cref="P:Microsoft.Data.SqlClient.SqlConnection.ConnectionString" />. The cancellation token can be used to request that the operation be abandoned before the connection timeout elapses.  Exceptions will be propagated via the returned Task. If the connection timeout time elapses without successfully connecting, the returned Task will be marked as faulted with an Exception. The implementation returns a Task without blocking the calling thread for both pooled and non-pooled connections.</summary>

doc/snippets/Microsoft.Data.SqlClient/SqlConnectionOverrides.xml

@@ -0,0 +1,17 @@
+<docs>
+    <members name="SqlConnectionOverrides">
+        <SqlConnectionOverrides>
+            <summary>
+                Specifies a value for Overrides.
+            </summary>
+        </SqlConnectionOverrides>
+        <None>
+            <summary>No overrides.</summary>
+            <value>0</value>
+        </None>
+        <OpenWithoutRetry>
+            <summary>Disable transient fault handling during the initial SqlConnection Open attempt.</summary>
+            <value>1</value>
+        </OpenWithoutRetry>
+    </members>
+</docs>

release-notes/2.0/2.0.0-preview3.md

@@ -0,0 +1,99 @@
+# Release Notes
+
+## Microsoft.Data.SqlClient 2.0.0-preview3.20122.2 released 1 May 2020
+
+This update brings the below changes over the previous release:
+
+### Added
+- Allow passing username with Active Directory Interactive Authentication in .NET Framework [#492](https://github.com/dotnet/SqlClient/pull/492)
+- Allow large UDT buffers for .NET Framework [#456](https://github.com/dotnet/SqlClient/pull/456) 
+- Added "Transaction Id" and "Client Version" in Diagnostic Source traces [#515](https://github.com/dotnet/SqlClient/pull/515)
+- Added new `SqlConnectionOverrides` APIs to perform `SqlConnection.Open()` with fail fast option [#463](https://github.com/dotnet/SqlClient/pull/463)
+
+### Fixed
+- Addressed MARS TDS Header errors by reverting changes to make `SqlDataReader.ReadAsync()` non-blocking [#547](https://github.com/dotnet/SqlClient/pull/547)
+- Fixed driver behavior to not perform enlistment of pooled connection in aborted transaction [#543](https://github.com/dotnet/SqlClient/pull/543)
+- Fixed wrong application domain selected when starting `SqlDependencyListener` [#410](https://github.com/dotnet/SqlClient/pull/410)
+- Added missing refs for `RowCopied` property in `SqlBulkCopy` [#508](https://github.com/dotnet/SqlClient/pull/508)
+
+### Changes
+- Improved performance by removing unwanted method calls in Event Source tracing [#506](https://github.com/dotnet/SqlClient/pull/506)
+- Removed Diagnostic Source and Configuration Manager dependencies from .NET Standard implementation [#535](https://github.com/dotnet/SqlClient/pull/535)
+- Removed redundant calls to `DbConnectionPoolKey.GetType()` [#512](https://github.com/dotnet/SqlClient/pull/512)
+
+### Breaking Changes
+- Updated driver to perform decimal scale rounding to match SQL Server behavior [#470](https://github.com/dotnet/SqlClient/pull/470)
+- Standardized App Context switch that enables Managed SNI on Windows for .NET Core and .NET Standard (break only applies to 2.0 preview releases that introduced the switch) [#548](https://github.com/dotnet/SqlClient/pull/548)
+
+
+### Enabling decimal truncation behavior conditionally
+Starting with v2.0.0-preview3, the decimal data scale will be rounded by the driver by default as is done by SQL Server.
+For backwards compatibility, you can set the [AppContext](https://docs.microsoft.com/en-us/dotnet/api/system.appcontext?view=netframework-4.8) switch "Switch.Microsoft.Data.SqlClient.TruncateScaledDecimal" to "true".
+
+To set the switch at application startup, specify:
+
+```cs
+AppContext.SetSwitch("Switch.Microsoft.Data.SqlClient.TruncateScaledDecimal", true);
+```
+
+### Enabling Managed networking on Windows
+This release introduces the renamed AppContext switch "Switch.Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows" that enables the use of Managed SNI instead of native SNI on Windows for testing and debugging purposes. This switch will toggle the driver's behavior to use Managed SNI in .NET Core 2.1+ and .NET Standard 2.0+ projects on Windows.
+
+To set the switch at application startup, specify:
+
+```cs
+AppContext.SetSwitch("Switch.Microsoft.Data.SqlClient.UseManagedNetworkingOnWindows", true);
+```
+
+## Target Platform Support
+
+- .NET Framework 4.6+
+- .NET Core 2.1+ (Windows x86, Windows x64, Linux, macOS)
+- .NET Standard 2.0+ (Windows x86, Windows x64, Linux, macOS)
+
+### Dependencies
+
+#### .NET Framework
+
+- Microsoft.Data.SqlClient.SNI 1.1.0+
+- Microsoft.Identity.Client 3.0.8
+- Microsoft.IdentityModel.Protocols.OpenIdConnect 5.6.0
+- Microsoft.IdentityModel.JsonWebTokens 5.6.0
+
+#### .NET Core 2.1
+
+- runtime.native.System.Data.SqlClient.sni 4.4.0 
+- Microsoft.Win32.Registry 4.7.0 
+- System.Security.Principal.Windows 4.7.0 
+- System.Text.Encoding.CodePages 4.7.0 
+- System.Diagnostics.DiagnosticSource 4.7.0 
+- System.Configuration.ConfigurationManager 4.7.0 
+- System.Runtime.Caching 4.7.0 
+- Microsoft.Identity.Client 4.7.1
+- Microsoft.IdentityModel.Protocols.OpenIdConnect 5.6.0
+- Microsoft.IdentityModel.JsonWebTokens 5.6.0
+
+#### .NET Core 3.1
+
+- runtime.native.System.Data.SqlClient.sni 4.4.0 
+- Microsoft.Win32.Registry 4.7.0 
+- System.Security.Principal.Windows 4.7.0 
+- System.Text.Encoding.CodePages 4.7.0 
+- System.Diagnostics.DiagnosticSource 4.7.0 
+- System.Configuration.ConfigurationManager 4.7.0 
+- System.Runtime.Caching 4.7.0 
+- Microsoft.Identity.Client 4.7.1
+- Microsoft.IdentityModel.Protocols.OpenIdConnect 5.6.0
+- Microsoft.IdentityModel.JsonWebTokens 5.6.0
+
+#### .NET Standard
+
+- runtime.native.System.Data.SqlClient.sni 4.4.0
+- Microsoft.Win32.Registry 4.7.0
+- System.Buffers 4.5.0
+- System.Memory 4.5.3
+- System.Security.Principal.Windows 4.7.0
+- System.Text.Encoding.CodePages 4.7.0
+- Microsoft.Identity.Client 4.7.1
+- Microsoft.IdentityModel.Protocols.OpenIdConnect 5.6.0
+- Microsoft.IdentityModel.JsonWebTokens 5.6.0

release-notes/2.0/2.0.md

@@ -6,3 +6,4 @@ The following Microsoft.Data.SqlClient 2.0 preview releases have been shipped:
 | :-- | :-- | :--: |
 | 2020/01/21 | 2.0.0-preview1.20021.1 | [release notes](2.0.0-preview1.md) |
 | 2020/03/24 | 2.0.0-preview2.20084.1 | [release notes](2.0.0-preview2.md) |
+| 2020/05/01 | 2.0.0-preview3.20122.2 | [release notes](2.0.0-preview3.md) |

release-notes/2.0/README.md

@@ -6,3 +6,4 @@ The following Microsoft.Data.SqlClient 2.0 preview releases have been shipped:
 | :-- | :-- | :--: |
 | 2020/01/21 | 2.0.0-preview1.20021.1 | [release notes](2.0.0-preview1.md) |
 | 2020/03/24 | 2.0.0-preview2.20084.1 | [release notes](2.0.0-preview2.md) |
+| 2020/05/01 | 2.0.0-preview3.20122.2 | [release notes](2.0.0-preview3.md) |

src/.dockerignore

@@ -0,0 +1,25 @@
+**/.classpath
+**/.dockerignore
+**/.env
+**/.git
+**/.gitignore
+**/.project
+**/.settings
+**/.toolstarget
+**/.vs
+**/.vscode
+**/*.*proj.user
+**/*.dbmdl
+**/*.jfm
+**/azds.yaml
+**/bin
+**/charts
+**/docker-compose*
+**/Dockerfile*
+**/node_modules
+**/npm-debug.log
+**/obj
+**/secrets.dev.yaml
+**/values.dev.yaml
+LICENSE
+README.md