Enable new PR pipelines (#3759)

Author: paulmedynski

eng/pipelines/dotnet-sqlclient-ci-core.yml

@@ -84,6 +84,12 @@ parameters:
 - name: testJobTimeout
   type: number
 
+# If true, the Always Encrypted (AE) test set will be run, which requires
+# Enclave-enabled SQL Server instances.
+- name: runAlwaysEncryptedTests
+  type: boolean
+  default: true
+
 variables:
   - template: libraries/ci-build-variables.yml@self
 
@@ -394,7 +400,9 @@ stages:
             LocalDbAppName: $(LocalDbAppName)
             LocalDbSharedInstanceName: $(LocalDbSharedInstanceName)
 
-        ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: # only run enclave jobs if the password is available
+        # Only run the AE tests if enable and if we have access to the necessary
+        # secrets.
+        ${{ if and(eq(parameters.runAlwaysEncryptedTests, true), eq(variables['system.pullRequest.isFork'], 'False')) }}:
           windows_enclave_sql:
             pool: ADO-CI-AE-1ES-Pool
             images: 
@@ -481,7 +489,9 @@ stages:
             LocalDbAppName: $(LocalDbAppName)
             LocalDbSharedInstanceName: $(LocalDbSharedInstanceName)
 
-        ${{ if eq(variables['system.pullRequest.isFork'], 'False') }}: # only run enclave jobs if the password is available
+        # Only run the AE tests if enable and if we have access to the necessary
+        # secrets.
+        ${{ if and(eq(parameters.runAlwaysEncryptedTests, true), eq(variables['system.pullRequest.isFork'], 'False')) }}:
           linux_enclave_sql:
             pool: ADO-CI-AE-1ES-Pool
             images:

eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml

@@ -11,12 +11,13 @@
 #   - Microsoft.Data.SqlClient
 #   - Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
 #
-# It runs via CI push triggers and schedules:
+# It runs via CI push triggers and schedules and uses the Release build
+# configuration:
 #
 #   - Commits to GitHub main
 #   - Commits to ADO internal/main
-#   - Weekdays at 01:00 UTC on GitHub main
-#   - Thursdays at 03:00 UTC on ADO internal/main
+#   - Weekdays at 03:00 UTC on GitHub main
+#   - Thursdays at 07:00 UTC on ADO internal/main
 #
 # GOTCHA: This pipeline definition is triggered by GitHub _and_ ADO CI.  We are
 # able to define different triggers and schedules using branch filters:
@@ -45,7 +46,8 @@ name: $(DayOfYear)$(Rev:rr)
 # Trigger this pipeline on commits to certain branches.
 trigger:
 
-  # Don't trigger a new run until the previous one completes.
+  # Don't trigger a new run until the previous one completes.  This may cause
+  # multiple commits to be batched into a single run.
   batch: true
 
   branches:
@@ -60,8 +62,9 @@ trigger:
     include:
     - .azuredevops
     - .config
-    - src
+    - doc
     - eng
+    - src
     - tools
     - azurepipelines-coverage.yml
     - build.proj
@@ -72,15 +75,15 @@ schedules:
 
   # GitHub main on weekdays
   - cron: '0 3 * * Mon-Fri'
-    displayName: Weekday Release Build
+    displayName: Weekday Run (Release Config)
     branches:
       include:
       - main
     always: true
 
   # ADO internal/main on Thursdays.
-  - cron: '0 5 * * Thu'
-    displayName: Thursday Release Build
+  - cron: '0 7 * * Thu'
+    displayName: Thursday Run (Release Config)
     branches:
       include:
       - internal/main
@@ -162,10 +165,10 @@ extends:
     # specified.  We choose different values depending on the build
     # configuration.
     ${{ if eq(parameters.testJobTimeout, 'Default') }}:
-      # If the build configuration is Debug, double the test job timeout value.
-      # Some of our tests currently take much longer to run in Debug mode.
+      # If the build configuration is Debug, we allow a bit of extra time since
+      # some tests run more slowly, and some tests are Debug only.
       ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
-        testJobTimeout: 180
+        testJobTimeout: 110
       ${{ else }}:
         testJobTimeout: 90
     ${{ else }}:

eng/pipelines/dotnet-sqlclient-ci-project-reference-pipeline.yml

@@ -11,12 +11,13 @@
 #   - Microsoft.Data.SqlClient
 #   - Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
 #
-# It runs via CI push triggers and schedules:
+# It runs via CI push triggers and schedules and uses the Release build
+# configuration:
 #
 #   - Commits to GitHub main
 #   - Commits to ADO internal/main
 #   - Weekdays at 01:00 UTC on GitHub main
-#   - Thursdays at 03:00 UTC on ADO internal/main
+#   - Thursdays at 05:00 UTC on ADO internal/main
 #
 # GOTCHA: This pipeline definition is triggered by GitHub _and_ ADO CI.  We are
 # able to define different triggers and schedules using branch filters:
@@ -45,7 +46,8 @@ name: $(DayOfYear)$(Rev:rr)
 # Trigger this pipeline on commits to certain branches.
 trigger:
 
-  # Don't trigger a new run until the previous one completes.
+  # Don't trigger a new run until the previous one completes.  This may cause
+  # multiple commits to be batched into a single run.
   batch: true
 
   branches:
@@ -60,8 +62,9 @@ trigger:
     include:
     - .azuredevops
     - .config
-    - src
+    - doc
     - eng
+    - src
     - tools
     - azurepipelines-coverage.yml
     - build.proj
@@ -72,15 +75,15 @@ schedules:
 
   # GitHub main on weekdays
   - cron: '0 1 * * Mon-Fri'
-    displayName: Weekday Release Build
+    displayName: Weekday Run (Release Config)
     branches:
       include:
       - main
     always: true
 
   # ADO internal/main on Thursdays.
-  - cron: '0 3 * * Thu'
-    displayName: Thursday Release Build
+  - cron: '0 5 * * Thu'
+    displayName: Thursday Run (Release Config)
     branches:
       include:
       - internal/main
@@ -151,7 +154,7 @@ extends:
   parameters:
     buildConfiguration: ${{ parameters.buildConfiguration }}
     buildPlatforms: ${{ parameters.buildPlatforms }}
-    buildType: Package
+    buildType: Project
     codeCovTargetFrameworks: ${{ parameters.codeCovTargetFrameworks }}
     debug: ${{ parameters.debug }}
     enableStressTests: ${{ parameters.enableStressTests }}
@@ -162,10 +165,10 @@ extends:
     # specified.  We choose different values depending on the build
     # configuration.
     ${{ if eq(parameters.testJobTimeout, 'Default') }}:
-      # If the build configuration is Debug, double the test job timeout value.
-      # Some of our tests currently take much longer to run in Debug mode.
+      # If the build configuration is Debug, we allow a bit of extra time since
+      # some tests run more slowly, and some tests are Debug only.
       ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
-        testJobTimeout: 180
+        testJobTimeout: 110
       ${{ else }}:
         testJobTimeout: 90
     ${{ else }}:

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

@@ -11,7 +11,8 @@
 #   - Microsoft.Data.SqlClient
 #   - Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
 #
-# It is triggered by pushes to PRs for dev/topic/feature branches in GitHub.
+# It is triggered by pushes to PRs that target dev/ and feature/ branches, and
+# the main branch in GitHub.
 #
 # It maps to the "PR-SqlClient-Package" pipeline in the Public project:
 #
@@ -29,18 +30,17 @@ pr:
   branches:
     include:
     # GitHub repo branch targets that will trigger PR validation builds.
-    # TODO: Temporarily restricting to my ci-debug branches only.
-    - dev/paul/ci-debug*
-    # - dev/*
-    # - feat/*
-    # - main
+    - dev/*
+    - feat/*
+    - main
 
   paths:
     include:
     - .azuredevops
     - .config
-    - src
+    - doc
     - eng
+    - src
     - tools
     - azurepipelines-coverage.yml
     - build.proj
@@ -122,12 +122,15 @@ extends:
     # specified.  We choose different values depending on the build
     # configuration.
     ${{ if eq(parameters.testJobTimeout, 'Default') }}:
-      # If the build configuration is Debug, double the test job timeout value.
-      # Some of our tests currently take much longer to run in Debug mode.
+      # If the build configuration is Debug, we allow a bit of extra time since
+      # some tests run more slowly, and some tests are Debug only.
       ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
-        testJobTimeout: 180
+        testJobTimeout: 110
       ${{ else }}:
         testJobTimeout: 90
     ${{ else }}:
       testJobTimeout: ${{ parameters.testJobTimeout }}
     useManagedSNI: ${{ parameters.useManagedSNI }}
+    # Don't run the AE tests in Debug mode; they rarely succeed.
+    ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
+      runAlwaysEncryptedTests: false

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

@@ -11,7 +11,8 @@
 #   - Microsoft.Data.SqlClient
 #   - Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
 #
-# It is triggered by pushes to PRs for dev/topic/feature branches in GitHub.
+# It is triggered by pushes to PRs that target dev/ and feature/ branches, and
+# the main branch in GitHub.
 #
 # It maps to the "PR-SqlClient-Project" pipeline in the Public project:
 #
@@ -29,18 +30,17 @@ pr:
   branches:
     include:
     # GitHub repo branch targets that will trigger PR validation builds.
-    # TODO: Temporarily restricting to my ci-debug branches only.
-    - dev/paul/ci-debug*
-    # - dev/*
-    # - feat/*
-    # - main
+    - dev/*
+    - feat/*
+    - main
 
   paths:
     include:
     - .azuredevops
     - .config
-    - src
+    - doc
     - eng
+    - src
     - tools
     - azurepipelines-coverage.yml
     - build.proj
@@ -122,12 +122,15 @@ extends:
     # specified.  We choose different values depending on the build
     # configuration.
     ${{ if eq(parameters.testJobTimeout, 'Default') }}:
-      # If the build configuration is Debug, double the test job timeout value.
-      # Some of our tests currently take much longer to run in Debug mode.
+      # If the build configuration is Debug, we allow a bit of extra time since
+      # some tests run more slowly, and some tests are Debug only.
       ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
-        testJobTimeout: 180
+        testJobTimeout: 110
       ${{ else }}:
         testJobTimeout: 90
     ${{ else }}:
       testJobTimeout: ${{ parameters.testJobTimeout }}
     useManagedSNI: ${{ parameters.useManagedSNI }}
+    # Don't run the AE tests in Debug mode; they rarely succeed.
+    ${{ if eq(parameters.buildConfiguration, 'Debug') }}:
+      runAlwaysEncryptedTests: false