Do not change behavior if route is null, only if it's empty

Elanis · Elanis · commit 0e9821c6605c · 2025-07-29T21:24:55.000+02:00
diff --git a/src/Hosting/Hosting/src/Internal/HostingMetrics.cs b/src/Hosting/Hosting/src/Internal/HostingMetrics.cs
@@ -67,12 +67,11 @@ public void RequestEnd(string protocol, string scheme, string method, string? ro
 
             // Add information gathered during request.
             tags.Add("http.response.status_code", GetBoxedStatusCode(statusCode));
-            var httpRoute = route;
-            if (string.IsNullOrEmpty(httpRoute))
+            if (route != null)
             {
-                httpRoute = "/";
+                var httpRoute = (route == string.Empty) ? "/" : route;
+                tags.Add("http.route", httpRoute);
             }
-            tags.Add("http.route", httpRoute);
 
             // Add before some built in tags so custom tags are prioritized when dealing with duplicates.
             if (customTags != null)

Original file line number	Diff line number	Diff line change
`@@ -67,12 +67,11 @@ public void RequestEnd(string protocol, string scheme, string method, string? ro`
`67`	`67`
`68`	`68`	`// Add information gathered during request.`
`69`	`69`	`tags.Add("http.response.status_code", GetBoxedStatusCode(statusCode));`
`70`		`- var httpRoute = route;`
`71`		`- if (string.IsNullOrEmpty(httpRoute))`
	`70`	`+ if (route != null)`
`72`	`71`	`{`
`73`		`- httpRoute = "/";`
	`72`	`+ var httpRoute = (route == string.Empty) ? "/" : route;`
	`73`	`+ tags.Add("http.route", httpRoute);`
`74`	`74`	`}`
`75`		`- tags.Add("http.route", httpRoute);`
`76`	`75`
`77`	`76`	`// Add before some built in tags so custom tags are prioritized when dealing with duplicates.`
`78`	`77`	`if (customTags != null)`