Replies: 2 comments 3 replies
-
|
I think it's fine to fix them, however we should keep in mind multiple things:
|
Beta Was this translation helpful? Give feedback.
-
|
Those are all manageable. Are you ok w/ a single PR? CISure (if you have a list of files/path patterns, that'd help, otherwise I'll try figure out which CI files to skip) Public APIIf you have a pattern for how to identify a public api, that'd help, otherwise I'll try to figure it out on my own rev-ignoreA rev-ignore file is fine, but note that your default approach appears to be a squash merge, in which case the rev-ignore file will need to be created by a follow-up PR. FSCompIt looks like you're asking to skip translation key fixes, that's fairly doable, only a handful of them are, specifically, I believe this is the set of problematic changes (which I've locally dropped). diffdiff --git a/src/Compiler/FSComp.txt b/src/Compiler/FSComp.txt
index ea2e2e5c0..dfb65fd4e 100644
--- a/src/Compiler/FSComp.txt
+++ b/src/Compiler/FSComp.txt
@@ -986,2 +986,2 @@ lexhlpIdentifierReserved,"The identifier '%s' is reserved for future use by F#"
-1106,matchMissingVariable,"Missing variable '%s'"
-1107,matchPartialActivePatternsGenerateOneResult,"Partial active patterns may only generate one result"
+1106,patcMissingVariable,"Missing variable '%s'"
+1107,patcPartialActivePatternsGenerateOneResult,"Partial active patterns may only generate one result"
@@ -1000 +1000 @@ lexhlpIdentifierReserved,"The identifier '%s' is reserved for future use by F#"
-lexfltIncorrectIndentationOfIn,"The indentation of this 'in' token is incorrect with respect to the corresponding 'let'"
+lexfltIncorrentIndentationOfIn,"The indentation of this 'in' token is incorrect with respect to the corresponding 'let'"
@@ -1036,2 +1036,2 @@ lexUnexpectedChar,"Unexpected character '%s'"
-1154,lexOutsideDecimal,"This number is outside the allowable range for decimal literals"
-1155,lexOutsideThirtyTwoBitFloat,"This number is outside the allowable range for 32-bit floats"
+1154,lexOusideDecimal,"This number is outside the allowable range for decimal literals"
+1155,lexOusideThirtyTwoBitFloat,"This number is outside the allowable range for 32-bit floats"
@@ -1385 +1385 @@ tcTupleStructMismatch,"One tuple type is a struct tuple, the other is a referenc
-3206,CallerMemberNameIsOverridden,"The CallerMemberNameAttribute applied to parameter '%s' will have no effect. It is overridden by the CallerFilePathAttribute."
+3206,CallerMemberNameIsOverriden,"The CallerMemberNameAttribute applied to parameter '%s' will have no effect. It is overridden by the CallerFilePathAttribute."I'm certainly happy to leave it as a distinct commit/PR if that makes things easier -- it doesn't matter to me |
Beta Was this translation helpful? Give feedback.
-
Yeah, fine with that.
Pretty much all yaml files and everything under eng directory.
Yes, that's every method and parameter names which is in the following file: https://github.com/dotnet/fsharp/blob/main/tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.SurfaceArea.netstandard20.release.bsl since people can be relying on names and it might be a breaking change for them.
Yeah, that would be fine.
Yeah, pretty much. They will trigger translation which might be long and heavy process.
In general I would also like to hear others' opinions. @dotnet/fsharp-team-msft |
Beta Was this translation helpful? Give feedback.
-
|
Opened #16212 -- it'll take me a while to annotate |
Beta Was this translation helpful? Give feedback.
-
|
Sure, I am all up for fixing the mistakes, aligning it with what Vlad says. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I have a workflow/action that I use to identify and correct typos in GitHub repositories.
It's used by a number of repositories, e.g. PowerToys
With this workflow, I've identified:
893 misspelled words
Additional errors
Details
check-file-path
Abrevis not a recognized word.Abrevis not a recognized word.Abstactis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Artificalis not a recognized word.Captialis not a recognized word.Concereteis not a recognized word.contrainsis not a recognized word.Discrimnantis not a recognized word.Embededis not a recognized word.Extentionis not a recognized word.Nallis not a recognized word.Nallis not a recognized word.Numericais not a recognized word.Paramertizedis not a recognized word.Polymorficis not a recognized word.Quotiationis not a recognized word.Signitureis not a recognized word.Signitureis not a recognized word.Signitureis not a recognized word.forbidden-pattern
and andmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.and andmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.and andmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.and andmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.any anymatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.assume assumematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.code codematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.dirty dirtymatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.each eachmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.file filematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.for formatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.hosting hostingmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.implies impliesmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.install installmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.more morematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.more morematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.new newmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.new newmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.new newmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.now nowmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.regression regressionmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.semantics semanticsmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.simple simplematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.some somematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.the thematches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.with withmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.with withmatches a line_forbidden.patterns entry:\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s.an othermatches a line_forbidden.patterns entry:\ban[- ]other\b.an othermatches a line_forbidden.patterns entry:\ban[- ]other\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Can notmatches a line_forbidden.patterns entry:\b[Cc]an not\b.Githubmatches a line_forbidden.patterns entry:(?<![&*.]|// |\btype )\bGithub\b(?![{)]).Githubmatches a line_forbidden.patterns entry:(?<![&*.]|// |\btype )\bGithub\b(?![{)]).Githubmatches a line_forbidden.patterns entry:(?<![&*.]|// |\btype )\bGithub\b(?![{)]).MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.MacOSmatches a line_forbidden.patterns entry:\bMacOS\b.non existingmatches a line_forbidden.patterns entry:\bnon existing\b.non existingmatches a line_forbidden.patterns entry:\bnon existing\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.non-existentmatches a line_forbidden.patterns entry:\b[Nn]o[nt][- ]existent\b.ore morematches a line_forbidden.patterns entry:\bore (?:more|less)\b.pre-existingmatches a line_forbidden.patterns entry:[Pp]re[- ]existing.pre-existingmatches a line_forbidden.patterns entry:[Pp]re[- ]existing.pre-existingmatches a line_forbidden.patterns entry:[Pp]re[- ]existing.pre-existingmatches a line_forbidden.patterns entry:[Pp]re[- ]existing.pre-existingmatches a line_forbidden.patterns entry:[Pp]re[- ]existing.re-entrancymatches a line_forbidden.patterns entry:[Rr]e[- ]entrancy.work aroundsmatches a line_forbidden.patterns entry:\bwork[- ]arounds\b.I have a changeset that I'd be happy to provide in some manner if the project is amenable to it: https://github.com/dotnet/fsharp/compare/main...jsoref:fsharp:spelling?expand=1
I'm more than happy to split by file path / extension or some other means (fancier splits will take longer, but I have a lot of experience doing this and am very patient).
Would this be of interest?
Beta Was this translation helpful? Give feedback.
All reactions