Improve too-large timeout handling in client poll

Author: dpkp

kafka/client_async.py

@@ -631,6 +631,11 @@ def _register_send_sockets(self):
                 self._selector.register(conn._sock, selectors.EVENT_WRITE, conn)
 
     def _poll(self, timeout):
+        # Python throws OverflowError if timeout is > 2147483647 milliseconds
+        # (though the param to selector.select is in seconds)
+        # so convert any too-large timeout to blocking
+        if timeout > 2147483:
+            timeout = None
         # This needs to be locked, but since it is only called from within the
         # locked section of poll(), there is no additional lock acquisition here
         processed = set()
@@ -639,8 +644,6 @@ def _poll(self, timeout):
         self._register_send_sockets()
 
         start_select = time.time()
-        if timeout == float('inf'):
-            timeout = None
         ready = self._selector.select(timeout)
         end_select = time.time()
         if self._sensors: