-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
a difference between your driver and others is that no callback is ever caller after all migrations is applied:
DBMigrate.getInstance(true,{})
.sync()
.then(() =>console.log('migration done'))
.catch((err) => console.log('migration failed', err))
will never have his then or catch called
I found that the source of this problem is that you never call the provided callback during driver.close(cb);
this callback is responsible for terminating the promise of all operations. (see db-migrate/lib/commands/on-complete.js:11)
do you still maintains this repository, and if so, would you merge a PR that fix this bug if I fill one ?
Clement134
Metadata
Metadata
Assignees
Labels
No labels