Return Invalid instead of panicking for unknown types

Author: mlafeldt

crates/duckdb/src/core/logical_type.rs

@@ -9,6 +9,7 @@ use crate::ffi::*;
 /// <https://duckdb.org/docs/api/c/types>
 #[repr(u32)]
 #[derive(Debug, PartialEq, Eq)]
+#[non_exhaustive]
 pub enum LogicalTypeId {
     /// Invalid
     Invalid = DUCKDB_TYPE_DUCKDB_TYPE_INVALID,
@@ -136,7 +137,9 @@ impl From<u32> for LogicalTypeId {
             DUCKDB_TYPE_DUCKDB_TYPE_STRING_LITERAL => Self::StringLiteral,
             DUCKDB_TYPE_DUCKDB_TYPE_INTEGER_LITERAL => Self::IntegerLiteral,
             DUCKDB_TYPE_DUCKDB_TYPE_TIME_NS => Self::TimeNs,
-            _ => panic!(),
+            // Return Invalid for unknown types to handle forward compatibility
+            // when DuckDB adds new types in future versions
+            _ => Self::Invalid,
         }
     }
 }

crates/duckdb/src/vtab/arrow.rs

@@ -25,9 +25,7 @@ use arrow::{
     record_batch::RecordBatch,
 };
 
-use libduckdb_sys::{
-    duckdb_date, duckdb_hugeint, duckdb_interval, duckdb_string_t, duckdb_time, duckdb_timestamp, duckdb_vector,
-};
+use libduckdb_sys::{duckdb_date, duckdb_string_t, duckdb_time, duckdb_timestamp, duckdb_vector};
 use num::{cast::AsPrimitive, ToPrimitive};
 
 /// A pointer to the Arrow record batch for the table function.
@@ -462,35 +460,25 @@ pub fn flat_vector_to_arrow_array(
 
             Ok(Arc::new(structs))
         }
-        LogicalTypeId::Struct => {
-            todo!()
-        }
-        LogicalTypeId::Decimal => {
-            todo!()
-        }
-        LogicalTypeId::Map => {
-            todo!()
-        }
-        LogicalTypeId::List => {
-            todo!()
-        }
-        LogicalTypeId::Union => {
-            todo!()
-        }
-        LogicalTypeId::Interval => {
-            let _data = vector.as_slice_with_len::<duckdb_interval>(len);
-            todo!()
-        }
-        LogicalTypeId::Hugeint => {
-            let _data = vector.as_slice_with_len::<duckdb_hugeint>(len);
-            todo!()
-        }
-        LogicalTypeId::Enum => {
-            todo!()
-        }
-        LogicalTypeId::Uuid => {
-            todo!()
-        }
+        LogicalTypeId::Interval => todo!(),
+        LogicalTypeId::Hugeint => todo!(),
+        LogicalTypeId::Decimal => todo!(),
+        LogicalTypeId::Enum => todo!(),
+        LogicalTypeId::List => todo!(),
+        LogicalTypeId::Struct => todo!(),
+        LogicalTypeId::Map => todo!(),
+        LogicalTypeId::Array => todo!(),
+        LogicalTypeId::Uuid => todo!(),
+        LogicalTypeId::Union => todo!(),
+        LogicalTypeId::Bit => todo!(),
+        LogicalTypeId::TimeTZ => todo!(),
+        LogicalTypeId::UHugeint => todo!(),
+        LogicalTypeId::Any => todo!(),
+        LogicalTypeId::Bignum => todo!(),
+        LogicalTypeId::SqlNull => todo!(),
+        LogicalTypeId::StringLiteral => todo!(),
+        LogicalTypeId::IntegerLiteral => todo!(),
+        LogicalTypeId::TimeNs => todo!(),
     }
 }