Skip to content

Commit fb2396f

Browse files
Create new feature flag for handling about blank web pages (#7132)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1211850430148973?focus=true ### Description Added a new toggle `handleAboutBlank()` to the `AndroidBrowserConfigFeature` interface. This toggle is internally always enabled and defaults to `false`. It will be used to determine whether the app should handle "about:blank" URLs based on remote configuration. ### Steps to test this PR _Handle About Blank Feature_ - [x] Verify that the new toggle is properly annotated with `@Toggle.InternalAlwaysEnabled` - [x] Verify that the toggle defaults to `false` when remote config is not present ### UI changes No UI or functional changes in this PR.
1 parent d214ec0 commit fb2396f

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,4 +203,14 @@ interface AndroidBrowserConfigFeature {
203203
*/
204204
@Toggle.DefaultValue(DefaultFeatureValue.FALSE)
205205
fun reportWebViewCapabilities(): Toggle
206+
207+
/**
208+
* @return `true` when the remote config has the global "handleAboutBlank" androidBrowserConfig
209+
* sub-feature flag enabled
210+
* If the remote feature is not present defaults to `false`
211+
*/
212+
// @Toggle.InternalAlwaysEnabled
213+
@Toggle.DefaultValue(DefaultFeatureValue.FALSE)
214+
@Toggle.InternalAlwaysEnabled
215+
fun handleAboutBlank(): Toggle
206216
}

0 commit comments

Comments
 (0)