From f9c604c8d9be35d47228d33164e4db05a4237e35 Mon Sep 17 00:00:00 2001 From: mihf05 Date: Mon, 6 Oct 2025 01:29:42 +0600 Subject: [PATCH 1/2] Fix tab switcher menu button visibility on real devices Fixes #6702 - Tab switcher '...' menu is invisible The issue was that the popup menu button was only having its isEnabled property set, but not its isVisible property. On some Android devices and different Android versions/themes, disabled menu items can become invisible or very faint, which caused the menu to not appear on real devices while still being visible on virtual devices. This fix ensures the popup menu button is always visible by explicitly setting isVisible = true, regardless of the enabled state. - Set explicit visibility for popup menu toolbar button - Add comment explaining the fix for future reference --- .../java/com/duckduckgo/app/tabs/ui/TabSwitcherMenuExt.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherMenuExt.kt b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherMenuExt.kt index 4e1d5bb29617..902555976c51 100644 --- a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherMenuExt.kt +++ b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherMenuExt.kt @@ -141,7 +141,10 @@ fun Menu.createDynamicInterface( } } - findItem(R.id.popupMenuToolbarButton).isEnabled = dynamicMenu.isMenuButtonEnabled + findItem(R.id.popupMenuToolbarButton).apply { + isEnabled = dynamicMenu.isMenuButtonEnabled + isVisible = true // Always show the menu button regardless of enabled state + } findItem(R.id.fireToolbarButton).isVisible = dynamicMenu.isFireButtonVisible findItem(R.id.duckAIToolbarButton).isVisible = dynamicMenu.isDuckAIButtonVisible findItem(R.id.newTabToolbarButton).isVisible = dynamicMenu.isNewTabButtonVisible From b01f2346090953880c4e9542b6b55042de4cdf62 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 5 Oct 2025 19:30:33 +0000 Subject: [PATCH 2/2] Initial plan