Skip to content

Conversation

@cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Sep 2, 2025

Description

This PR improves latency tests by removing Log Filters and fixing the test destruction. It also adds configuration for the reliable tests.

This will not be backported to 2.14 as the performance test suite is different from the one used in Fast DDS 3.x

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.4.0 milestone Sep 2, 2025
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Use keep_all history

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Alloc resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 2, 2025
@cferreiragonz cferreiragonz removed the request for review from richiprosima September 2, 2025 14:59
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025

🧪 CI Insights

Here's what we observed from your CI run for a79d472.

🟢 All jobs passed!

But CI Insights is watching 👀

@rsanchez15 rsanchez15 merged commit b39ed87 into master Sep 11, 2025
27 of 28 checks passed
@rsanchez15 rsanchez15 deleted the improve_latency_tests branch September 11, 2025 06:50
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 3.3.x 3.2.x

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2025

backport 3.3.x 3.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 11, 2025
* Refs #23482: Remove Log filter

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Fix destruction of latency tests

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Make reliable tests keep_all with allocated resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Use keep_all history

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Alloc resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Apply changes to udp too

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit b39ed87)
mergify bot pushed a commit that referenced this pull request Sep 11, 2025
* Refs #23482: Remove Log filter

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Fix destruction of latency tests

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Make reliable tests keep_all with allocated resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Use keep_all history

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Alloc resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Apply changes to udp too

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit b39ed87)
MiguelCompany pushed a commit that referenced this pull request Oct 10, 2025
* Refs #23482: Remove Log filter

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Fix destruction of latency tests

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Make reliable tests keep_all with allocated resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Use keep_all history

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Alloc resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Apply changes to udp too

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit b39ed87)
MiguelCompany pushed a commit that referenced this pull request Oct 12, 2025
* Refs #23482: Remove Log filter



* Refs #23482: Fix destruction of latency tests



* Refs #23482: Make reliable tests keep_all with allocated resources



Use keep_all history



Alloc resources



* Refs #23482: Apply changes to udp too



---------


(cherry picked from commit b39ed87)

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz added a commit that referenced this pull request Oct 14, 2025
* Refs #23482: Remove Log filter

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Fix destruction of latency tests

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Make reliable tests keep_all with allocated resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Use keep_all history

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Alloc resources

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23482: Apply changes to udp too

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit b39ed87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants