-
Notifications
You must be signed in to change notification settings - Fork 872
[23482] Improve latency tests #5998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cd13ab to
315bf58
Compare
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Use keep_all history Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Alloc resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
315bf58 to
a79d472
Compare
🧪 CI InsightsHere's what we observed from your CI run for a79d472. 🟢 All jobs passed!But CI Insights is watching 👀 |
Carlosespicur
approved these changes
Sep 10, 2025
|
@Mergifyio backport 3.3.x 3.2.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Refs #23482: Remove Log filter Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Fix destruction of latency tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Make reliable tests keep_all with allocated resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Use keep_all history Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Alloc resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Apply changes to udp too Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit b39ed87)
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Refs #23482: Remove Log filter Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Fix destruction of latency tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Make reliable tests keep_all with allocated resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Use keep_all history Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Alloc resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Apply changes to udp too Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit b39ed87)
This was referenced Sep 11, 2025
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 10, 2025
* Refs #23482: Remove Log filter Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Fix destruction of latency tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Make reliable tests keep_all with allocated resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Use keep_all history Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Alloc resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Apply changes to udp too Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit b39ed87)
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 12, 2025
* Refs #23482: Remove Log filter * Refs #23482: Fix destruction of latency tests * Refs #23482: Make reliable tests keep_all with allocated resources Use keep_all history Alloc resources * Refs #23482: Apply changes to udp too --------- (cherry picked from commit b39ed87) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Oct 14, 2025
* Refs #23482: Remove Log filter Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Fix destruction of latency tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Make reliable tests keep_all with allocated resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Use keep_all history Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Alloc resources Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23482: Apply changes to udp too Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit b39ed87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves latency tests by removing Log Filters and fixing the test destruction. It also adds configuration for the reliable tests.
This will not be backported to 2.14 as the performance test suite is different from the one used in Fast DDS 3.x
@Mergifyio backport 3.3.x 3.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist