fix(initCommands): move commands to be executed before attaching

The current behavior described in documentation is misleading:
"commands sent before attaching to inferior." The commands are sent after
the GDB is attached, which is too late, especially if you wanted to set
e.g. the baudrate. The "preRunCommands" should be executed after
the connection to target.

Author: andy9a9

src/desktop/GDBTargetDebugSession.ts

@@ -572,6 +572,11 @@ export class GDBTargetDebugSession extends GDBDebugSession {
                 }
             }
 
+            // Send GDB commands before attaching to target
+            await this.executeOrAbort(this.gdb.sendCommands.bind(this.gdb))(
+                args.initCommands
+            );
+
             await this.setSessionState(SessionState.GDB_READY);
 
             // Connect to remote server
@@ -620,11 +625,6 @@ export class GDBTargetDebugSession extends GDBDebugSession {
 
             await this.setSessionState(SessionState.CONNECTED);
 
-            // Initialize debug target
-            await this.executeOrAbort(this.gdb.sendCommands.bind(this.gdb))(
-                args.initCommands
-            );
-
             // Initialize UART
             if (target.uart !== undefined) {
                 this.initializeUARTConnection(target.uart, target.host);

src/gdb/GDBDebugSessionBase.ts

@@ -339,6 +339,8 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {
         }
         await this.gdb.sendEnablePrettyPrint();
 
+        await this.gdb.sendCommands(args.initCommands);
+
         if (request === 'attach') {
             this.isAttach = true;
             const attachArgs = args as AttachRequestArguments;
@@ -350,8 +352,6 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {
             );
         }
 
-        await this.gdb.sendCommands(args.initCommands);
-
         if (request === 'launch') {
             const launchArgs = args as LaunchRequestArguments;
             if (launchArgs.arguments) {

src/web/GDBTargetDebugSession.ts

@@ -421,6 +421,11 @@ export class GDBTargetDebugSession extends GDBDebugSession {
                 }
             }
 
+            // Send GDB commands before attaching to target
+            await this.executeOrAbort(this.gdb.sendCommands.bind(this.gdb))(
+                args.initCommands
+            );
+
             await this.setSessionState(SessionState.GDB_READY);
 
             // Connect to remote server
@@ -469,11 +474,6 @@ export class GDBTargetDebugSession extends GDBDebugSession {
 
             await this.setSessionState(SessionState.CONNECTED);
 
-            // Initialize debug target
-            await this.executeOrAbort(this.gdb.sendCommands.bind(this.gdb))(
-                args.initCommands
-            );
-
             // Load additional code/symbols
             if (args.imageAndSymbols) {
                 if (args.imageAndSymbols.imageFileName) {