ExtendedQueryCommandBaseCodec not close prepare statement while receive an error packet

[onebite]

Questions

while execute prepare sql encounter an error, more info errorCode=1062 sqlState=23000， client will received an error packet. Then, we miss to close prepare statement, see the function handleErrorPacketPayload.

Version

4.2.4

[tsegismont]

@onebite thank you. Can you provide a reproducer?

[tsegismont]

From the info provided in the description, it looks like this may happen while working with MySQL and getting a Duplicate Entry primary key constraint violation.

[tsegismont]

I was able to reproduce with:

  @Test
  public void testPreparedStatementCleaned(TestContext ctx) {
    Assume.assumeFalse(MySQLTestBase.rule.isUsingMySQL5_6() || MySQLTestBase.rule.isUsingMariaDB());
    MySQLConnectOptions connectOptions = new MySQLConnectOptions(options)
      .setUser("root")
      .setPassword("password")
      .setCachePreparedStatements(false);
    Async async = ctx.async();
    MySQLConnection.connect(vertx, connectOptions, ctx.asyncAssertSuccess(conn -> {
      conn.query("SELECT * FROM performance_schema.prepared_statements_instances").execute(ctx.asyncAssertSuccess(res1 -> {
        ctx.assertEquals(0, res1.size());
        conn.preparedQuery("INSERT INTO duplicate_test VALUES (?)").execute(Tuple.of(1), ctx.asyncAssertFailure(failure -> {
          if (!(failure instanceof MySQLException)) {
            ctx.fail(failure);
            return;
          }
          MySQLException e = (MySQLException) failure;
          ctx.assertEquals(1062, e.getErrorCode());
          ctx.assertEquals("23000", e.getSqlState());
          conn.query("SELECT * FROM performance_schema.prepared_statements_instances").execute(ctx.asyncAssertSuccess(res3 -> {
            ctx.assertEquals(0, res3.size()); // ! Fails here
            conn.close(ctx.asyncAssertSuccess(v -> {
              async.complete();
            }));
          }));
        }));
      }));
    }));
  }

Which fails with

java.lang.AssertionError: Not equals : 0 != 1