Merge pull request #761 from amvanbaren/feature/issue-613

Update review list right after user posting/revoking

Author: amvanbaren

server/src/main/java/org/eclipse/openvsx/RegistryAPI.java

@@ -894,7 +894,7 @@ public ResponseEntity<ReviewListJson> getReviews(
         for (var registry : getRegistries()) {
             try {
                 return ResponseEntity.ok()
-                        .cacheControl(CacheControl.maxAge(10, TimeUnit.MINUTES).cachePublic())
+                        .cacheControl(CacheControl.noCache().cachePublic())
                         .body(registry.getReviews(namespace, extension));
             } catch (NotFoundException exc) {
                 // Try the next registry
@@ -1012,7 +1012,7 @@ public ResponseEntity<SearchResultJson> search(
         }
 
         return ResponseEntity.ok()
-                .cacheControl(CacheControl.maxAge(10, TimeUnit.MINUTES).cachePublic())
+                .cacheControl(CacheControl.noCache().cachePublic())
                 .body(result);
     }
 

server/src/main/java/org/eclipse/openvsx/web/ShallowEtagHeaderFilter.java

@@ -15,15 +15,12 @@
 public class ShallowEtagHeaderFilter extends org.springframework.web.filter.ShallowEtagHeaderFilter {
 
     protected boolean shouldNotFilter(HttpServletRequest request) throws ServletException {
-        // limit the filter to /api/{namespace}/{extension}, /api/{namespace}/details
-        // and /api/{namespace}/{extension}/{version} endpoints
+        // limit the filter to /api/{namespace}/{extension}, /api/{namespace}/details,
+        // /api/{namespace}/{extension}/{version}, and /api/-/search endpoints
         var path = request.getRequestURI().substring(1).split("/");
-        var applyFilter = path.length == 3 || path.length == 4;
-        if(applyFilter) {
-            applyFilter = path[0].equals("api") && !path[1].equals("-");
-        }
-        if(applyFilter && path.length == 4) {
-            applyFilter = !(path[3].equals("review") || path[3].equals("reviews"));
+        var applyFilter = (path.length == 3 || path.length == 4) && path[0].equals("api");
+        if(applyFilter && path[1].equals("-")) {
+            applyFilter = path[2].contains("search");
         }
 
         return !applyFilter;

webui/src/pages/extension-detail/extension-review-dialog.tsx

@@ -109,9 +109,9 @@ class ExtensionReviewDialogComponent extends React.Component<ExtensionReviewDial
             return null;
         }
         return <React.Fragment>
-            <Button variant='contained' color='secondary' onClick={this.handleOpenButton}>
+            {!this.state.posted && (<Button variant='contained' color='secondary' onClick={this.handleOpenButton}>
                 Write a Review
-            </Button>
+            </Button>)}
             <Dialog open={this.state.open} onClose={this.handleCancel}>
                 <DialogTitle>{this.props.extension.displayName || this.props.extension.name} Review</DialogTitle>
                 <DialogContent>