-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[IRONSCALES] - Fix Cannot execute ILM policy delete step #138094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IRONSCALES] - Fix Cannot execute ILM policy delete step #138094
Conversation
|
Pinging @elastic/es-security (Team:Security) |
|
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Note: we usually would not grant the system user access to data indexes, but there is an exception for logs-* patterns (documented here).
Could you update the "kibana_system privileges" spreadsheet? I'll DM you a link. I'll DM @mohitjha-elastic to see how to proceed.
|
@jeramysoucy |
jeramysoucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the details and for updating the spreadsheet!
|
buildkite test this |
|
buildkite test this please |
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
) * Add ILM index for delete previlege * Add changelog entry --------- Co-authored-by: Mohit Jha <138874484+mohitjha-elastic@users.noreply.github.com> (cherry picked from commit 1ff2b5d)
PR Description:
This PR focuses on the short term solution which add the
logs-ironscales.incident-*indice under thekibana_systemrole with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PR. As it ships transform pipeline too hence read, write permissions are also required.Current behavior:
It shows permission issue while deleting the index.
Closes - #138093
Relates - elastic/integrations#15982