-
Notifications
You must be signed in to change notification settings - Fork 508
[Neon Cyber] New Elastic integration neon_cyber for the Neon Cyber platform #15725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
💚 CLA has been signed |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add this file, it will be automatically generated.
| @@ -0,0 +1,45 @@ | |||
| {{- generatedHeader }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was in the template and adds the auto generation "Do not edit" in the rendered README.md
packages/neon_cyber/changelog.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| # newer versions go on top | |||
| - version: "1.0.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with GA from the outset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be more conservative with 0.1.0
| - drop: | ||
| description: Ignore retry placeholder message. | ||
| if: ctx.message == "retry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
| if: ctx.message == "retry" | ||
| - set: | ||
| field: ecs.version | ||
| value: 8.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| value: 8.11.0 | |
| value: 8.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Processors should have tags to allow failures to be identified in the error message. Also below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
packages/neon_cyber/manifest.yml
Outdated
| - name: url | ||
| type: url | ||
| title: URL | ||
| default: https://api.neoncyber.io/v1 | ||
| description: Base URL of the Neon Cyber API | ||
| multi: false | ||
| required: true | ||
| show_user: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ever used AFAICS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I understand now, removing package URL for data stream resource url.
| - name: api_token | ||
| type: password | ||
| title: API Token | ||
| description: Neon Cyber developer API token | ||
| multi: false | ||
| required: true | ||
| show_user: true | ||
| secret: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this shared for all endpoints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/CODEOWNERS needs to be updated to include this package with the owner matching the owner in the package's manifest.
packages/neon_cyber/manifest.yml
Outdated
| show_user: false | ||
| owner: | ||
| github: elastic/security-service-integrations | ||
| type: elastic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This likely should be either "community" or "partner" depending on the arrangement here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to partner
update dep ref version Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Proposed commit message
Changes made
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots