Skip to content

[Qualys GAV] - Added support for comma separated list of IPv4 addresses in network_interface list data #15782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

[Qualys GAV] - Added support for comma separated list of IPv4 addresses in network_interface list data #15782

merged 2 commits into from
Oct 29, 2025
+463 −17

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 28, 2025 •
edited
Loading

Type of change

  • Bug

Proposed commit message

Current implementation fails to process logs where the ipv4
address in network_interface list data is a comma separated string
literal. This PR addresses that parsing issue.

NOTE:

The newly added test uses a modified existing log to reproduce our use-case. No new logs or customer sensitive data has been added/used in this test.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG self-assigned this Oct 28, 2025
@ShourieG ShourieG requested a review from a team as a code owner October 28, 2025 09:52
@ShourieG ShourieG added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:qualys_gav Qualys Global AssetView labels Oct 28, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

efd6
efd6 approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, otherwise LGTM

@ShourieG ShourieG merged commit e5127ff into elastic:main Oct 29, 2025
7 checks passed
@ShourieG ShourieG deleted the bugfix/qualys_gav_15155 branch October 29, 2025 07:52
@elastic-vault-github-plugin-prod
Copy link

Package qualys_gav - 0.3.1 containing this change is available at https://epr.elastic.co/package/qualys_gav/0.3.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels

bugfix Pull request that fixes a bug issue Integration:qualys_gav Qualys Global AssetView Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[qualys_gav]: Incorrect parsing of ip_v4

3 participants

@ShourieG @elasticmachine @efd6