ASAR Integrity assumes a single asar file is present

[t3chguy]

An application may use multiple ASARs and want integrity for all of them, but merging packages using @electron/universal breaks that.

Related electron-userland/electron-builder#8660

The main process code lives in app.asar and the renderer/webapp code lives in webapp.asar (for complicated reasons). We'd like integrity enabled at least on the app.asar but it seems like the fuse applies to all ASARs, and due to merging universal packages causing the integrity to get clobbered that is problematic.

[7727:0122/164306.527723:FATAL:archive.cc(239)] Failed to get integrity for validatable asar archive: Resources/webapp.asar

[mmaietta]

Note to the electron devs, I'm happy to pick up working on this issue after #117. 🙃 I just rewrote electron-builders asar integrity calculation to handle multi-asar project setups, so it should be easy to port over to electron/universal.

[continuous-auth]

🎉 This issue has been resolved in version 2.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[t3chguy]

Thanks @mmaietta & @BlackHole1 - I will test this soon

[t3chguy]

@mmaietta I am now getting an error I wasn't before. Its possible I am misconfigured or maybe electron-builder needs to update rather than me (ab)using resolutions to get @electron/universal early.

https://github.com/element-hq/element-desktop/actions/runs/13585583560/job/37979734197?pr=2169#step:12:31

I believe the file it is complaining about is a universal binary so is expected to be the same between the two ASARs

 ~/W/element-desktop   t3chguy/dockerfile-env-format  file node_modules/keytar/build/Release/keytar.node 
node_modules/keytar/build/Release/keytar.node: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit bundle x86_64] [arm64:Mach-O 64-bit bundle arm64]
node_modules/keytar/build/Release/keytar.node (for architecture x86_64):        Mach-O 64-bit bundle x86_64
node_modules/keytar/build/Release/keytar.node (for architecture arm64): Mach-O 64-bit bundle arm64

Edit: looks to be expected https://github.com/electron/universal#skip-lipo-for-certain-binaries-in-your-universal-app - wonder why it wasn't an issue before this

Confused by the naming including x64 when it wants you to list universal binaries, but specifying .node there seems to have made it happy and do the right thing. Thanks again

[mmaietta]

Coincidentally, I have a PR open for handling universal macho files as well: #126