chore(cli): exclude lockfiles from embedded samples; remove lockfiles from sources #1634
+74
−744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1582 by removing and preventing lockfiles in embedded sample templates.
Changes:
package-lock.kdlfromktwebandweb-static-workersample sourcespackages/cli/src/projects/samples.jsonto stop referencing the lockfilepackages/cli/build.gradle.ktsto exclude common ecosystem lockfiles (npm/yarn/pnpm, Cargo, Pip, Poetry, Bundler, and Gradle dependency locks)Why:
Verification:
:packages:cli:packSamplesand inspectedpackages/cli/build/packed-samples/*.zip— no lockfiles included (e.g.,web-static-worker.zipcontains no lockfile)ktweb.zipnow only includeselide.pklas expected (no lockfile)Follow-up:
elide initfor web samples should no longer contain lockfiles.Fixes #1582