Skip to content

Conversation

@akapug
Copy link
Member

@akapug akapug commented Sep 10, 2025

Ready for review Powered by Pull Request Badge

This PR addresses #1582 by removing and preventing lockfiles in embedded sample templates.

Changes:

  • Remove package-lock.kdl from ktweb and web-static-worker sample sources
  • Update packages/cli/src/projects/samples.json to stop referencing the lockfile
  • Harden sample packing in packages/cli/build.gradle.kts to exclude common ecosystem lockfiles (npm/yarn/pnpm, Cargo, Pip, Poetry, Bundler, and Gradle dependency locks)

Why:

  • Lockfiles in cross-platform samples can cause breakage/encoding issues and stale pins. Samples should resolve fresh on first install.

Verification:

  • Ran :packages:cli:packSamples and inspected packages/cli/build/packed-samples/*.zip — no lockfiles included (e.g., web-static-worker.zip contains no lockfile)
  • ktweb.zip now only includes elide.pkl as expected (no lockfile)

Follow-up:

  • New projects created via elide init for web samples should no longer contain lockfiles.

Fixes #1582

… from sources\n\n- Remove package-lock.kdl from ktweb and web-static-worker samples\n- Stop referencing lockfile in samples.json\n- Exclude common ecosystem lockfiles during sample packing\n\nFixes #1582
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.98%. Comparing base (5a2cc4e) to head (0b1dbf3).
⚠️ Report is 128 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   39.98%   39.98%           
=======================================
  Files         783      783           
  Lines       37433    37433           
  Branches     5295     5295           
=======================================
  Hits        14969    14969           
  Misses      20675    20675           
  Partials     1789     1789           
Flag Coverage Δ
jvm 39.98% <ø> (ø)
lib 39.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2cc4e...0b1dbf3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon closed this Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't add lockfiles to samples

4 participants