Skip to content

visual-line integration does not affect [down] and [up] #1971

@fuyu0425

Description

@fuyu0425

Hi evil developers! Thanks for this awesome package.
Is there any specific reason/concern not to change [down] and [up] also for visual-line integration?

evil/evil-integration.el

Lines 435 to 445 in 682e87f

(when evil-respect-visual-line-mode
(evil-define-minor-mode-key 'motion 'visual-line-mode
"j" 'evil-next-visual-line
"gj" 'evil-next-line
"k" 'evil-previous-visual-line
"gk" 'evil-previous-line
"0" 'evil-beginning-of-visual-line
"g0" 'evil-beginning-of-line
"$" 'evil-end-of-visual-line
"g$" 'evil-end-of-line
"V" 'evil-visual-screen-line))

I expect it to work for them though.

(evil-define-minor-mode-key 'motion 'visual-line-mode
  "j" 'evil-next-visual-line
  [down] 'evil-next-visual-line
  "gj" 'evil-next-line
  (vconcat "g" [down]) 'evil-next-line
  "k" 'evil-previous-visual-line
  [up] 'evil-previous-visual-line
  "gk" 'evil-previous-line
  (vconcat "g" [up]) 'evil-next-line
  "0" 'evil-beginning-of-visual-line
  "g0" 'evil-beginning-of-line
  "$" 'evil-end-of-visual-line
  "g$" 'evil-end-of-line
  "V" 'evil-visual-screen-line)

How do you think?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions