You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 1, 2022. It is now read-only.
Today I used patch-package to patch react-canvas-draw@1.2.1 for the project I'm working on.
I'm calculating the size of the canvas based on the size of the image and the size of the screen to make sure the image always fits the screen. When I tried editing images that were much taller than wider I got an error like this:
Cannot read properties of undefined (reading 'getPointerCoordinates')
The easiest way to reproduce the problem for me was to set canvasWidth={100} and canvasHeight={400} and then I consistently reproduced the error.
Here is the diff that solved my problem:
diff --git a/node_modules/react-canvas-draw/es/index.js b/node_modules/react-canvas-draw/es/index.js
index a089ebc..5469492 100644
--- a/node_modules/react-canvas-draw/es/index.js+++ b/node_modules/react-canvas-draw/es/index.js@@ -458,7 +458,7 @@ var CanvasDraw = /*#__PURE__*/function (_PureComponent) {
_ref4$once = _ref4.once,
once = _ref4$once === void 0 ? false : _ref4$once;
- if (_this.mouseHasMoved || _this.valuesChanged) {+ if (_this.lazy && (_this.mouseHasMoved || _this.valuesChanged)) {
var pointer = _this.lazy.getPointerCoordinates();
var brush = _this.lazy.getBrushCoordinates();