fix: add SerializationError retrying (#62)

Author: emptybutton

src/ttt/application/common/ports/retry.py

@@ -0,0 +1,6 @@
+from abc import ABC, abstractmethod
+
+
+class Retry(ABC):
+    @abstractmethod
+    def __bool__(self) -> bool: ...

src/ttt/application/stars_purchase/start_stars_purchase_payment.py

@@ -4,6 +4,7 @@
 
 from ttt.application.common.ports.clock import Clock
 from ttt.application.common.ports.map import Map
+from ttt.application.common.ports.retry import Retry
 from ttt.application.common.ports.transaction import SerializableTransaction
 from ttt.application.common.ports.uuids import UUIDs
 from ttt.application.stars_purchase.ports.stars_purchase_log import (
@@ -26,8 +27,9 @@ class StartStarsPurchasePayment:
     payment_gateway: StarsPurchasePaymentGateway
     map_: Map
     log: StarsPurchaseLog
+    retry: Retry
 
-    async def __call__(self, purchase_id: UUID, retry: bool) -> None:  # noqa: FBT001
+    async def __call__(self, purchase_id: UUID) -> None:
         """
         :raises ttt.application.common.errors.serialization_error.SerializationError:
         """  # noqa: E501
@@ -57,7 +59,7 @@ async def __call__(self, purchase_id: UUID, retry: bool) -> None:  # noqa: FBT00
                 )
                 await self.transaction.commit()
 
-                if retry:
+                if self.retry:
                     await self.payment_gateway.start_payment(payment_id)
                 else:
                     await self.payment_gateway.stop_payment_due_to_dublicate(

src/ttt/application/stars_purchase/start_stars_purchase_payment_completion.py

@@ -1,16 +1,9 @@
 from dataclasses import dataclass
 from uuid import UUID
 
-from ttt.application.common.ports.transaction import ReadonlyTransaction
-from ttt.application.stars_purchase.ports.stars_purchase_locks import (
-    StarsPurchaseLocks,
-)
 from ttt.application.stars_purchase.ports.stars_purchase_log import (
     StarsPurchaseLog,
 )
-from ttt.application.stars_purchase.ports.stars_purchase_payment_gateway import (  # noqa: E501
-    StarsPurchasePaymentGateway,
-)
 from ttt.application.stars_purchase.ports.stars_purchase_tasks import (
     StarsPurchaseTasks,
 )
@@ -23,10 +16,8 @@
 @dataclass(frozen=True, unsafe_hash=False)
 class StartStarsPurchasePaymentCompletion:
     tasks: StarsPurchaseTasks
-    payment_gateway: StarsPurchasePaymentGateway
     views: StarsPurchaseViews
     log: StarsPurchaseLog
-    locks: StarsPurchaseLocks
 
     async def __call__(
         self,

src/ttt/infrastructure/adapters/retry.py

@@ -0,0 +1,12 @@
+from dataclasses import dataclass
+
+from ttt.application.common.ports.retry import Retry
+from ttt.infrastructure.retrier import Retrier
+
+
+@dataclass
+class RetrierRetry(Retry):
+    _retries: Retrier
+
+    def __bool__(self) -> bool:
+        return self._retries.retry()

src/ttt/infrastructure/retrier.py

@@ -0,0 +1,43 @@
+from collections.abc import Callable
+from dataclasses import dataclass, field
+
+
+type MaxRetries = int
+type Retries = int
+
+
+@dataclass
+class Retrier:
+    _max_retries_map: dict[type[BaseException], MaxRetries]
+
+    _retries_map: dict[type[BaseException], Retries] = field(
+        init=False, default_factory=dict,
+    )
+
+    def retry(self) -> bool:
+        return bool(self._retries_map)
+
+    async def __call__[**PmT, RT](
+        self,
+        action: Callable[PmT, RT],
+        *args: PmT.args,
+        **kwargs: PmT.kwargs,
+    ) -> RT:
+        while True:
+            try:
+                return action(*args, **kwargs)
+            except BaseException as error:
+                if type(error) not in self._max_retries_map:
+                    raise error from error
+
+                for error_type, max_retries in self._max_retries_map.items():
+                    if not isinstance(error, error_type):
+                        continue
+
+                    if error_type not in self._retries_map:
+                        self._retries_map[error_type] = 0
+
+                    self._retries_map[error_type] += 1
+
+                    if self._retries_map[error_type] > max_retries:
+                        raise error from error

src/ttt/infrastructure/taskiq/tasks/complete_stars_purchase_payment_task.py

@@ -6,6 +6,7 @@
     CompleteStarsPurchasePayment,
 )
 from ttt.entities.finance.payment.success import PaymentSuccess
+from ttt.infrastructure.retrier import Retrier
 from ttt.infrastructure.taskiq.broker import NatsBroker
 
 
@@ -26,10 +27,9 @@ async def complete_stars_purchase_payment_task(
     payment_success_id: str,
     payment_success_gateway_id: str,
     complete_stars_purchase_payment: FromDishka[CompleteStarsPurchasePayment],
+    retrier: FromDishka[Retrier],
 ) -> None:
     payment_success = PaymentSuccess(
         payment_success_id, payment_success_gateway_id,
     )
-    await complete_stars_purchase_payment(
-        purchase_id, payment_success,
-    )
+    await retrier(complete_stars_purchase_payment, purchase_id, payment_success)

src/ttt/infrastructure/taskiq/tasks/make_ai_move_in_game_task.py

@@ -3,6 +3,7 @@
 from dishka.integrations.taskiq import FromDishka, inject
 
 from ttt.application.game.game.make_ai_move_in_game import MakeAiMoveInGame
+from ttt.infrastructure.retrier import Retrier
 from ttt.infrastructure.taskiq.broker import NatsBroker
 
 
@@ -21,5 +22,6 @@ async def make_ai_move_in_game_broker_task(
     game_id: UUID,
     ai_id: UUID,
     make_ai_move_in_game: FromDishka[MakeAiMoveInGame],
+    retrier: FromDishka[Retrier],
 ) -> None:
-    await make_ai_move_in_game(user_id, game_id, ai_id)
+    await retrier(make_ai_move_in_game, user_id, game_id, ai_id)

src/ttt/main/common/di.py

@@ -13,9 +13,11 @@
     create_async_engine,
 )
 
+from ttt.application.common.errors.serialization_error import SerializationError
 from ttt.application.common.ports.clock import Clock
 from ttt.application.common.ports.map import Map
 from ttt.application.common.ports.randoms import Randoms
+from ttt.application.common.ports.retry import Retry
 from ttt.application.common.ports.transaction import (
     NotSerializableTransaction,
     ReadonlyTransaction,
@@ -79,6 +81,7 @@
     TokenAsOriginalAdminToken,
 )
 from ttt.infrastructure.adapters.randoms import MersenneTwisterRandoms
+from ttt.infrastructure.adapters.retry import RetrierRetry
 from ttt.infrastructure.adapters.stars_purchase_log import (
     StructlogStarsPurchaseLog,
 )
@@ -104,6 +107,7 @@
 from ttt.infrastructure.openai.gemini import Gemini, gemini
 from ttt.infrastructure.pydantic_settings.envs import Envs
 from ttt.infrastructure.pydantic_settings.secrets import Secrets
+from ttt.infrastructure.retrier import Retrier
 from ttt.infrastructure.taskiq.broker import NatsBrokers
 from ttt.infrastructure.taskiq.tasks.complete_stars_purchase_payment_task import complete_stars_purchase_payment_broker
 from ttt.infrastructure.taskiq.tasks.make_ai_move_in_game_task import make_ai_move_in_game_broker
@@ -342,3 +346,9 @@ def provide_randoms(self) -> Randoms:
         provides=StarsPurchaseTasks,
         scope=Scope.APP,
     )
+
+    @provide(scope=Scope.REQUEST)
+    def provide_retrier(self) -> Retrier:
+        return Retrier(_max_retries_map={SerializationError: 10})
+
+    provide_retry = provide(RetrierRetry, provides=Retry, scope=Scope.REQUEST)

src/ttt/presentation/adapters/stars_purchase_payment_gateway.py

@@ -56,8 +56,3 @@ async def stop_payment_due_to_error(self, payment_id: UUID) -> None:
             ok=False,
             error_message=message,
         )
-
-
-# INVOICE
-# OK?
-# | PAY  | Dulicate

src/ttt/presentation/aiogram/user/routes/handle_payment.py

@@ -3,12 +3,12 @@
 from dishka import AsyncContainer
 from dishka.integrations.aiogram import inject
 
-from ttt.application.stars_purchase.dto.common import PaidStarsPurchasePayment
 from ttt.application.stars_purchase.start_stars_purchase_payment_completion import (  # noqa: E501
     StartStarsPurchasePaymentCompletion,
 )
 from ttt.entities.finance.payment.success import PaymentSuccess
 from ttt.entities.tools.assertion import not_none
+from ttt.infrastructure.retrier import Retrier
 from ttt.presentation.aiogram.user.invoices import (
     StarsPurchaseInvoicePayload,
     invoce_payload_adapter,
@@ -36,12 +36,13 @@ async def _(
 
     match invoce_payload:
         case StarsPurchaseInvoicePayload():
+            retrier = await dishka_container.get(Retrier)
             start_stars_purchase_payment_completion = (
                 await dishka_container.get(StartStarsPurchasePaymentCompletion)
             )
-            payment = PaidStarsPurchasePayment(
-                invoce_payload.purchase_id,
+            await retrier(
+                start_stars_purchase_payment_completion,
                 invoce_payload.user_id,
+                invoce_payload.purchase_id,
                 success,
             )
-            await start_stars_purchase_payment_completion(payment)