Skip to content

Conversation

@mmyelyn
Copy link
Contributor

@mmyelyn mmyelyn commented May 14, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

There is a requirement for large screen mode(before large text) for a11y.
Since the purpose is to increase the screen magnification, the name large screen mode was used.

Resolution

When you pass the screenScale prop to resolutionDecorator, the base font size is calculated using that value.

Additional Considerations

Links

WRQ-2288

Comments

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (7c03337) to head (2a695af).
Report is 39 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3235      +/-   ##
===========================================
+ Coverage    82.41%   82.62%   +0.21%     
===========================================
  Files          156      156              
  Lines         7209     7285      +76     
  Branches      1907     1926      +19     
===========================================
+ Hits          5941     6019      +78     
+ Misses         997      995       -2     
  Partials       271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seunghoh
Copy link
Member

Please check the missed checkbox in the description.
Please pass the codecov block before request merge this PR.

mmyelyn added 2 commits May 23, 2024 14:39
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
@mmyelyn mmyelyn marked this pull request as draft July 5, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants