From 4376d3b56296f71708e1a95960e47ac6c44dc8c7 Mon Sep 17 00:00:00 2001 From: "taeyoung.hong" Date: Wed, 14 Feb 2024 21:19:41 +0900 Subject: [PATCH 1/5] fix lint error --- MediaOverlay/tests/MediaOverlay-specs.js | 2 -- TooltipDecorator/useTooltip.js | 2 -- VideoPlayer/tests/Video-specs.js | 2 -- package-lock.json | 4 ++-- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/MediaOverlay/tests/MediaOverlay-specs.js b/MediaOverlay/tests/MediaOverlay-specs.js index b26765d7a8..3eafab6009 100644 --- a/MediaOverlay/tests/MediaOverlay-specs.js +++ b/MediaOverlay/tests/MediaOverlay-specs.js @@ -1,5 +1,3 @@ -/* global HTMLMediaElement */ - import '@testing-library/jest-dom'; import {render, screen} from '@testing-library/react'; diff --git a/TooltipDecorator/useTooltip.js b/TooltipDecorator/useTooltip.js index e6587a51ff..bc155b1c1d 100644 --- a/TooltipDecorator/useTooltip.js +++ b/TooltipDecorator/useTooltip.js @@ -1,5 +1,3 @@ -/* global MutationObserver ResizeObserver */ - import {forward} from '@enact/core/handle'; import {Job} from '@enact/core/util'; import {useI18nContext} from '@enact/i18n/I18nDecorator'; diff --git a/VideoPlayer/tests/Video-specs.js b/VideoPlayer/tests/Video-specs.js index 6b13b74734..6eb00f1ffc 100644 --- a/VideoPlayer/tests/Video-specs.js +++ b/VideoPlayer/tests/Video-specs.js @@ -1,5 +1,3 @@ -/* global HTMLMediaElement */ - import '@testing-library/jest-dom'; import {render, screen} from '@testing-library/react'; diff --git a/package-lock.json b/package-lock.json index 642024929a..f96de1c98c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@enact/sandstone", - "version": "2.7.13", + "version": "2.8.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@enact/sandstone", - "version": "2.7.13", + "version": "2.8.0", "license": "Apache-2.0", "dependencies": { "@enact/core": "^4.8.0", From 749f81e8a76e6f234719f0e822d6e4cd565c4e87 Mon Sep 17 00:00:00 2001 From: "taeyoung.hong" Date: Thu, 15 Feb 2024 15:57:03 +0900 Subject: [PATCH 2/5] remove unused disable line --- tests/ui/specs/Scroller/Scroller-utils.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/ui/specs/Scroller/Scroller-utils.js b/tests/ui/specs/Scroller/Scroller-utils.js index 7d6d8e465f..f8fbd595a3 100644 --- a/tests/ui/specs/Scroller/Scroller-utils.js +++ b/tests/ui/specs/Scroller/Scroller-utils.js @@ -6,14 +6,12 @@ async function disabledAttribute () { async function enableEditModeLongPress () { await browser.execute(() => { - // eslint-disable-next-line no-undef const event = new KeyboardEvent('keydown', {code: 'Enter', key: 'Enter', keyCode: 13, repeat: true}); const element = document.activeElement; element.dispatchEvent(event); }); await browser.pause(500); await browser.execute(() => { - // eslint-disable-next-line no-undef const event = new KeyboardEvent('keyup', {code: 'Enter', key: 'Enter', keyCode: 13}); const element = document.activeElement; element.dispatchEvent(event); From a921975ffb19feb167ba1cbdba07816ed85aa9fc Mon Sep 17 00:00:00 2001 From: "taeyoung.hong" Date: Fri, 16 Feb 2024 10:07:54 +0900 Subject: [PATCH 3/5] remove unused disable line 2 --- Alert/Alert.js | 2 +- samples/qa-a11y/src/views/ImageItem.js | 2 +- samples/qa-a11y/src/views/Panels.js | 2 +- samples/qa-a11y/src/views/VideoPlayer.js | 1 - samples/qa-a11y/src/views/VirtualGridList.js | 1 - samples/qa-a11y/src/views/VirtualList.js | 1 - 6 files changed, 3 insertions(+), 6 deletions(-) diff --git a/Alert/Alert.js b/Alert/Alert.js index 157b5dba65..b9af7519e2 100644 --- a/Alert/Alert.js +++ b/Alert/Alert.js @@ -37,7 +37,7 @@ import css from './Alert.module.less'; * @public */ const AlertBase = kind({ - name: 'Alert', + // name: 'Alert', propTypes: /** @lends sandstone/Alert.AlertBase.prototype */ { /** diff --git a/samples/qa-a11y/src/views/ImageItem.js b/samples/qa-a11y/src/views/ImageItem.js index 21842bdb0c..7e770a60c1 100644 --- a/samples/qa-a11y/src/views/ImageItem.js +++ b/samples/qa-a11y/src/views/ImageItem.js @@ -7,7 +7,7 @@ import appCss from '../App/App.module.less'; const SelectableImageItem = (props) => { const [checked, setChecked] = useState(false); - const handleClick = () => !props.disabled && setChecked(!checked); // eslint-disable-line enact/prop-types + const handleClick = () => !props.disabled && setChecked(!checked); return ; // eslint-disable-line react/jsx-no-bind }; diff --git a/samples/qa-a11y/src/views/Panels.js b/samples/qa-a11y/src/views/Panels.js index 0f6038700c..0436643444 100644 --- a/samples/qa-a11y/src/views/Panels.js +++ b/samples/qa-a11y/src/views/Panels.js @@ -17,7 +17,7 @@ const PanelsView = () => { const nextPanel = () => setIndex(1); const prevPanel = () => setIndex(0); - const customItem = ({index: itemIndex, ...rest}) => { // eslint-disable-line enact/prop-types + const customItem = ({index: itemIndex, ...rest}) => { return ( {itemList[itemIndex]} diff --git a/samples/qa-a11y/src/views/VideoPlayer.js b/samples/qa-a11y/src/views/VideoPlayer.js index 7a3908583f..099ce83c9a 100644 --- a/samples/qa-a11y/src/views/VideoPlayer.js +++ b/samples/qa-a11y/src/views/VideoPlayer.js @@ -21,7 +21,6 @@ for (let i = 0; i < 20; i++) { items.push({source}); } -// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => { const {source} = items[index]; diff --git a/samples/qa-a11y/src/views/VirtualGridList.js b/samples/qa-a11y/src/views/VirtualGridList.js index d1905f20ba..5c45370d47 100644 --- a/samples/qa-a11y/src/views/VirtualGridList.js +++ b/samples/qa-a11y/src/views/VirtualGridList.js @@ -17,7 +17,6 @@ const svgGenerator = (width, height, bgColor, textColor, customText) => ( `%3Ctext x='50%25' y='50%25' dominant-baseline='middle' text-anchor='middle' font-size='36px' fill='%23${textColor}'%3E${customText}%3C/text%3E%3C/svg%3E` ); -// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => { const {caption, label, src} = items[index]; diff --git a/samples/qa-a11y/src/views/VirtualList.js b/samples/qa-a11y/src/views/VirtualList.js index 2119de47b5..5f962381c9 100644 --- a/samples/qa-a11y/src/views/VirtualList.js +++ b/samples/qa-a11y/src/views/VirtualList.js @@ -8,7 +8,6 @@ import ri from '@enact/ui/resolution'; import {useState} from 'react'; const items = []; -// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => ( {items[index]} From 774c7b282c5796511366c4f78e3e536c1c3d7bd4 Mon Sep 17 00:00:00 2001 From: "taeyoung.hong" Date: Fri, 16 Feb 2024 10:31:18 +0900 Subject: [PATCH 4/5] fix wrong comment --- Alert/Alert.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Alert/Alert.js b/Alert/Alert.js index b9af7519e2..157b5dba65 100644 --- a/Alert/Alert.js +++ b/Alert/Alert.js @@ -37,7 +37,7 @@ import css from './Alert.module.less'; * @public */ const AlertBase = kind({ - // name: 'Alert', + name: 'Alert', propTypes: /** @lends sandstone/Alert.AlertBase.prototype */ { /** From dc6fc0a594e24e03086222804ee7b2858a6024b3 Mon Sep 17 00:00:00 2001 From: "taeyoung.hong" Date: Fri, 16 Feb 2024 10:49:54 +0900 Subject: [PATCH 5/5] revert 'remove unused disable line 2' --- samples/qa-a11y/src/views/ImageItem.js | 2 +- samples/qa-a11y/src/views/Panels.js | 2 +- samples/qa-a11y/src/views/VideoPlayer.js | 1 + samples/qa-a11y/src/views/VirtualGridList.js | 1 + samples/qa-a11y/src/views/VirtualList.js | 1 + 5 files changed, 5 insertions(+), 2 deletions(-) diff --git a/samples/qa-a11y/src/views/ImageItem.js b/samples/qa-a11y/src/views/ImageItem.js index 7e770a60c1..21842bdb0c 100644 --- a/samples/qa-a11y/src/views/ImageItem.js +++ b/samples/qa-a11y/src/views/ImageItem.js @@ -7,7 +7,7 @@ import appCss from '../App/App.module.less'; const SelectableImageItem = (props) => { const [checked, setChecked] = useState(false); - const handleClick = () => !props.disabled && setChecked(!checked); + const handleClick = () => !props.disabled && setChecked(!checked); // eslint-disable-line enact/prop-types return ; // eslint-disable-line react/jsx-no-bind }; diff --git a/samples/qa-a11y/src/views/Panels.js b/samples/qa-a11y/src/views/Panels.js index 0436643444..0f6038700c 100644 --- a/samples/qa-a11y/src/views/Panels.js +++ b/samples/qa-a11y/src/views/Panels.js @@ -17,7 +17,7 @@ const PanelsView = () => { const nextPanel = () => setIndex(1); const prevPanel = () => setIndex(0); - const customItem = ({index: itemIndex, ...rest}) => { + const customItem = ({index: itemIndex, ...rest}) => { // eslint-disable-line enact/prop-types return ( {itemList[itemIndex]} diff --git a/samples/qa-a11y/src/views/VideoPlayer.js b/samples/qa-a11y/src/views/VideoPlayer.js index 099ce83c9a..7a3908583f 100644 --- a/samples/qa-a11y/src/views/VideoPlayer.js +++ b/samples/qa-a11y/src/views/VideoPlayer.js @@ -21,6 +21,7 @@ for (let i = 0; i < 20; i++) { items.push({source}); } +// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => { const {source} = items[index]; diff --git a/samples/qa-a11y/src/views/VirtualGridList.js b/samples/qa-a11y/src/views/VirtualGridList.js index 5c45370d47..d1905f20ba 100644 --- a/samples/qa-a11y/src/views/VirtualGridList.js +++ b/samples/qa-a11y/src/views/VirtualGridList.js @@ -17,6 +17,7 @@ const svgGenerator = (width, height, bgColor, textColor, customText) => ( `%3Ctext x='50%25' y='50%25' dominant-baseline='middle' text-anchor='middle' font-size='36px' fill='%23${textColor}'%3E${customText}%3C/text%3E%3C/svg%3E` ); +// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => { const {caption, label, src} = items[index]; diff --git a/samples/qa-a11y/src/views/VirtualList.js b/samples/qa-a11y/src/views/VirtualList.js index 5f962381c9..2119de47b5 100644 --- a/samples/qa-a11y/src/views/VirtualList.js +++ b/samples/qa-a11y/src/views/VirtualList.js @@ -8,6 +8,7 @@ import ri from '@enact/ui/resolution'; import {useState} from 'react'; const items = []; +// eslint-disable-next-line enact/prop-types const renderItem = ({index, ...rest}) => ( {items[index]}