Skip to content

breaking change in 3.19.x for restricted cluster access #459

@mozemke

Description

@mozemke

hi!

the changes made in #379 seem to have been breaking an existing use case.
to be precise:

with 3.18.x we were able to run the exporter in a multi tenant environment. By setting --include-namespace=ns1 --include-namespace=ns2 .. we were able to avoid needing cluster wide rights.
With the changes mentioned above you change the functionality of listNamespacesToWatch now even though no labels are set it needs cluster wide permissions.

Proposal:
a) check if include labels are set before making a cluster wide search
b) only search for include-labels OR include-namespaces, instead of offering both at the same time

Looking forward! :)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions