Add text, title, target to link #167
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the LinkProperty type to include additional metadata fields (text, title, and target) beyond just the URL, bringing it closer to standard HTML link attributes.
- Updated TypeScript type inference for LinkProperty to include text, title, and target fields
- Modified GraphQL query generation to fetch the additional link metadata
- Updated test snapshots to reflect the expanded query structure
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/optimizely-cms-sdk/src/infer.ts | Expanded the LinkProperty type definition to include text, title, and target fields alongside the existing url field |
| packages/optimizely-cms-sdk/src/graph/createQuery.ts | Modified the GraphQL query builder to request text, title, and target fields for link properties |
| packages/optimizely-cms-sdk/src/graph/test/createQuery.test.ts | Updated test snapshot expectations to match the new query structure with additional link fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohanPetersson
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the fields
title,targetandtextto thelinkproperties. Replaces #159