Merge pull request #16757 from ethereum/removeDevconnectApps

remove devconnect banner on /apps page

Author: wackerow

app/[locale]/apps/_components/DevconnectBanner.tsx

@@ -13,11 +13,7 @@ import I18nProvider from "@/components/I18nProvider"
 import MainArticle from "@/components/MainArticle"
 import SubpageCard from "@/components/SubpageCard"
 
-import {
-  getDevconnectApps,
-  getDiscoverApps,
-  getHighlightedApps,
-} from "@/lib/utils/apps"
+import { getDiscoverApps, getHighlightedApps } from "@/lib/utils/apps"
 import { getAppPageContributorInfo } from "@/lib/utils/contributors"
 import { dataLoader } from "@/lib/utils/data/dataLoader"
 import { getMetadata } from "@/lib/utils/metadata"
@@ -30,7 +26,6 @@ import { BASE_TIME_UNIT } from "@/lib/constants"
 import AppCard from "./_components/AppCard"
 import AppsHighlight from "./_components/AppsHighlight"
 import CommunityPicks from "./_components/CommunityPicks"
-import DevconnectBanner from "./_components/DevconnectBanner"
 import SuggestAnApp from "./_components/SuggestAnApp"
 import TopApps from "./_components/TopApps"
 import AppsJsonLD from "./page-jsonld"
@@ -62,9 +57,6 @@ const Page = async ({ params }: { params: PageParams }) => {
   // Get 6 random staff pick apps
   const discoverApps = getDiscoverApps(appsData, 6)
 
-  // get devconnect apps
-  const devconnectApps = getDevconnectApps(appsData)
-
   // Get translations
   const t = await getTranslations({ locale, namespace: "page-apps" })
 
@@ -104,10 +96,6 @@ const Page = async ({ params }: { params: PageParams }) => {
             <AppsHighlight apps={highlightedApps} matomoCategory="apps" />
           </div>
 
-          <div className="flex flex-col gap-4 px-4 md:px-8">
-            <DevconnectBanner apps={devconnectApps} />
-          </div>
-
           <div className="flex flex-col gap-4 px-4 md:px-8">
             <h2>{t("page-apps-discover-title")}</h2>
             <div className="grid grid-cols-1 gap-7 md:grid-cols-2 lg:grid-cols-3">

app/[locale]/apps/page.tsx

@@ -120,8 +120,6 @@
   "page-index-values-open-legacy-content-0": "Companies protect their intellectual property and don’t share. No one outside the company can see how things work, fix problems, or make improvements. It's hard for people to create new tools or customize.",
   "page-index-values-open-ethereum-label": "Open to all",
   "page-index-values-open-ethereum-content-0": "Ethereum is public to all. Anyone can see, use, and improve the code, making it better for everyone.",
-  "page-index-devconnect-banner-join-the-biggest-ethereum-event-of-the-year": "Join the biggest Ethereum event of the year",
-  "page-index-devconnect-banner-get-tickets": "Get tickets",
   "page-index-fusaka-network-upgrade": "Network upgrade",
   "page-index-fusaka-description": "For a faster, safer, and more user-friendly Ethereum network |",
   "page-index-fusaka-read-more": "Read more",

src/intl/en/page-index.json

@@ -32,13 +32,6 @@ export const getDiscoverApps = (
   return count ? discoverApps.slice(0, count) : discoverApps
 }
 
-export const getDevconnectApps = (appsData: Record<AppCategory, AppData[]>) => {
-  const devconnectApps = Object.values(appsData)
-    .flatMap((categoryDapps) => categoryDapps)
-    .filter((app) => app.devconnect === "true")
-  return devconnectApps
-}
-
 export const APP_TAG_VARIANTS: Record<AppCategoryEnum, TagProps["status"]> = {
   [AppCategoryEnum.DEFI]: "tag",
   [AppCategoryEnum.COLLECTIBLE]: "success",