core/vm: don't call SetCode after contract creation if initcode didn't return anything (#32916)

jwasinger · web-flow · commit b6a4ac996103 · 2025-10-20T11:51:29.000+02:00
The code change is a noop here, and the tracing hook shouldn't be
invoked if the account code doesn't actually change.
diff --git a/core/vm/evm.go b/core/vm/evm.go
@@ -601,7 +601,9 @@ func (evm *EVM) initNewContract(contract *Contract, address common.Address) ([]b
 		}
 	}
 
-	evm.StateDB.SetCode(address, ret, tracing.CodeChangeContractCreation)
+	if len(ret) > 0 {
+		evm.StateDB.SetCode(address, ret, tracing.CodeChangeContractCreation)
+	}
 	return ret, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -601,7 +601,9 @@ func (evm EVM) initNewContract(contract Contract, address common.Address) ([]b`
`601`	`601`	`}`
`602`	`602`	`}`
`603`	`603`
`604`		`- evm.StateDB.SetCode(address, ret, tracing.CodeChangeContractCreation)`
	`604`	`+ if len(ret) > 0 {`
	`605`	`+ evm.StateDB.SetCode(address, ret, tracing.CodeChangeContractCreation)`
	`606`	`+ }`
`605`	`607`	`return ret, nil`
`606`	`608`	`}`
`607`	`609`