eth/filters: avoid rebuild the hash map multi times #32965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
previously approved these changes
Oct 20, 2025
cbysal
reviewed
Oct 20, 2025
rjl493456442
approved these changes
Oct 20, 2025
rjl493456442
pushed a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Oct 28, 2025
This was referenced Nov 3, 2025
rjl493456442
pushed a commit
that referenced
this pull request
Nov 13, 2025
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
prestoalvarez
pushed a commit
to prestoalvarez/go-ethereum
that referenced
this pull request
Nov 27, 2025
prestoalvarez
pushed a commit
to prestoalvarez/go-ethereum
that referenced
this pull request
Nov 27, 2025
fjl
pushed a commit
to lightclient/go-ethereum
that referenced
this pull request
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When every new
ChainEventcomes, it can trigger the building of aHashMap, so to avoid that, we can build theHashMapat the beginning. This way can also prevent being attacked by mock hashes from dishonest clients.