Skip to content

Conversation

@holgerd77
Copy link
Member

General follow-up on #3976, direct follow-up on #4157
Implements #4156

This PR expands the 4844 constructor(s) and the serialization methods to integrate the 7594 network wrapper version. Additionally it adds new helpers to the Util blob helper module.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.75%. Comparing base (a2878a6) to head (f1cb4fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.58% <ø> (ø)
blockchain 89.37% <ø> (ø)
common 97.43% <ø> (ø)
evm 72.39% <ø> (ø)
mpt 89.74% <ø> (ø)
statemanager 80.21% <ø> (ø)
static 99.77% <ø> (ø)
tx 88.23% <65.71%> (-0.44%) ⬇️
util 89.77% <100.00%> (+0.87%) ⬆️
vm 57.24% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holgerd77
Copy link
Member Author

No review for a week, will take this in, post-merge review still appreciated.

Sepolia tx is working with this though:
https://sepolia.etherscan.io/tx/0x4a7cc4ab9b1b8174e9b65dabb18d5118cecbf224919be8030aef7b91998a6478

So this means that the network wrapper serialization method is correct. I am honestly not sure if this means/says anything about the cell proof being correct if the tx is accepted by the network? 🤔 Any insights here?

(actually I could try to send with modfied proofs and see what happens, might do that if some capacity)

@holgerd77 holgerd77 merged commit a8e0e8a into master Oct 28, 2025
32 of 33 checks passed
@holgerd77 holgerd77 deleted the implement-4844-tx-peerdas-serialization branch October 28, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants