Do not throw an error when pug template is not valid

Author: ezhlobo

lib/rules/no-undef.js

@@ -3,8 +3,7 @@
  * @author Eugene Zhlobo
  */
 
-const { findVariablesInTemplate } = require('pug-uses-variables')
-const { isReactPugReference, getTemplate } = require('../utilities')
+const { isReactPugReference, getTemplate, extractVariables } = require('../utilities')
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -38,7 +37,7 @@ module.exports = {
         if (isReactPugReference(node)) {
           const template = getTemplate(node)
 
-          const usedVariables = findVariablesInTemplate(template)
+          const usedVariables = extractVariables(template)
           const definedVariables = getDefinedVariables()
 
           const isVariableDefined = variable => !definedVariables.includes(variable.value)

lib/rules/uses-vars.js

@@ -3,8 +3,7 @@
  * @author Eugene Zhlobo
  */
 
-const { findVariablesInTemplate } = require('pug-uses-variables')
-const { isReactPugReference, getTemplate } = require('../utilities')
+const { isReactPugReference, getTemplate, extractVariables } = require('../utilities')
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -26,7 +25,7 @@ module.exports = {
         if (isReactPugReference(node)) {
           const template = getTemplate(node)
 
-          findVariablesInTemplate(template)
+          extractVariables(template)
             .forEach(variable => context.markVariableAsUsed(variable.value))
         }
       },

lib/utilities.js

@@ -1,3 +1,5 @@
+const { findVariablesInTemplate } = require('pug-uses-variables')
+
 const getQuasiValue = ({ value }) => {
   if (value && typeof value === 'object') {
     return value.raw.trimRight()
@@ -29,7 +31,16 @@ function getTemplate({ quasi }) {
   return getQuasiValue(quasis[0])
 }
 
+function extractVariables(template) {
+  try {
+    return findVariablesInTemplate(template)
+  } catch (e) {
+    return []
+  }
+}
+
 module.exports = {
   isReactPugReference,
   getTemplate,
+  extractVariables,
 }

tests/broken-template.js

@@ -0,0 +1,46 @@
+const fs = require('fs')
+const path = require('path')
+const { Linter } = require('eslint')
+
+const customRules = fs.readdirSync(path.join(process.cwd(), 'lib/rules'))
+  .reduce((files, filename) => {
+    const key = `react-pug/${filename.replace(/\.js$/, '')}`
+
+    // eslint-disable-next-line no-param-reassign, global-require, import/no-dynamic-require
+    files[key] = require(path.join(process.cwd(), `lib/rules/${filename}`))
+
+    return files
+  }, {})
+
+const linter = new Linter()
+
+linter.defineRules(customRules)
+
+const rulesSetting = Object.keys(customRules)
+  .reduce((files, ruleName) => {
+    // eslint-disable-next-line no-param-reassign
+    files[ruleName] = 2
+    return files
+  }, {})
+
+describe('broken-template', () => {
+  const configuration = {
+    globals: {
+      pug: true,
+    },
+    parserOptions: {
+      sourceType: 'module',
+    },
+    rules: rulesSetting,
+  }
+
+  it('does not throw an exception', () => {
+    const template = `
+      pug\`
+        each item, index in 1, 2, 3]
+      \`
+    `
+
+    linter.verify(template, configuration, 'foo.js')
+  })
+})