From 6ccab5d1829652166c24fb7437b3b43344a58039 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?helen=2Eone=28=E1=84=80=E1=85=A1=E1=86=BC=E1=84=92?= =?UTF-8?q?=E1=85=A8=E1=84=8B=E1=85=AF=E1=86=AB=29/kakao?= Date: Thu, 12 Dec 2024 14:49:13 +0900 Subject: [PATCH 1/4] Add Daum app user agent --- src/enums/ua-parser-enums.d.ts | 1 + src/enums/ua-parser-enums.js | 1 + src/enums/ua-parser-enums.mjs | 1 + src/main/ua-parser.js | 1 + src/main/ua-parser.mjs | 1 + test/data/ua/browser/browser-all.json | 20 ++++++++++++++++++++ 6 files changed, 25 insertions(+) diff --git a/src/enums/ua-parser-enums.d.ts b/src/enums/ua-parser-enums.d.ts index 5c406c393..406622d7f 100644 --- a/src/enums/ua-parser-enums.d.ts +++ b/src/enums/ua-parser-enums.d.ts @@ -29,6 +29,7 @@ export const Browser: Readonly<{ COBALT: "Cobalt"; COC_COC: "Coc Coc"; CONKEROR: "Conkeror"; + DAUM: "Daum"; DILLO: "Dillo"; DOLPHIN: "Dolphin"; DORIS: "Doris"; diff --git a/src/enums/ua-parser-enums.js b/src/enums/ua-parser-enums.js index 08a7afc7a..afa7d29c1 100644 --- a/src/enums/ua-parser-enums.js +++ b/src/enums/ua-parser-enums.js @@ -34,6 +34,7 @@ const Browser = Object.freeze({ COBALT: 'Cobalt', COC_COC: 'Coc Coc', CONKEROR: 'Conkeror', + DAUM: 'Daum', DILLO: 'Dillo', DOLPHIN: 'Dolphin', DORIS: 'Doris', diff --git a/src/enums/ua-parser-enums.mjs b/src/enums/ua-parser-enums.mjs index 276b8a268..210139867 100644 --- a/src/enums/ua-parser-enums.mjs +++ b/src/enums/ua-parser-enums.mjs @@ -38,6 +38,7 @@ const Browser = Object.freeze({ COBALT: 'Cobalt', COC_COC: 'Coc Coc', CONKEROR: 'Conkeror', + DAUM: 'Daum', DILLO: 'Dillo', DOLPHIN: 'Dolphin', DORIS: 'Doris', diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js index 0fa08b985..7585a557d 100755 --- a/src/main/ua-parser.js +++ b/src/main/ua-parser.js @@ -420,6 +420,7 @@ /(Klarna)\/([\w\.]+)/i, // Klarna Shopping Browser for iOS & Android /(kakao(?:talk|story))[\/ ]([\w\.]+)/i, // Kakao App /(naver)\(.*?(\d+\.[\w\.]+).*\)/i, // Naver InApp + /(daumapps)[\/ ]([\w\.]+)/i, // Daum App /safari (line)\/([\w\.]+)/i, // Line App for iOS /\b(line)\/([\w\.]+)\/iab/i, // Line App for Android /(alipay)client\/([\w\.]+)/i, // Alipay diff --git a/src/main/ua-parser.mjs b/src/main/ua-parser.mjs index 09dbce366..a4ccee30e 100644 --- a/src/main/ua-parser.mjs +++ b/src/main/ua-parser.mjs @@ -401,6 +401,7 @@ /(Klarna)\/([\w\.]+)/i, // Klarna Shopping Browser for iOS & Android /(kakao(?:talk|story))[\/ ]([\w\.]+)/i, // Kakao App /(naver)\(.*?(\d+\.[\w\.]+).*\)/i, // Naver InApp + /(daumapps)[\/ ]([\w\.]+)/i, // Daum App /safari (line)\/([\w\.]+)/i, // Line App for iOS /\b(line)\/([\w\.]+)\/iab/i, // Line App for Android /(alipay)client\/([\w\.]+)/i, // Alipay diff --git a/test/data/ua/browser/browser-all.json b/test/data/ua/browser/browser-all.json index 45a8e0789..00a3349c2 100644 --- a/test/data/ua/browser/browser-all.json +++ b/test/data/ua/browser/browser-all.json @@ -2503,6 +2503,26 @@ "type" : "inapp" } }, + { + "desc" : "Daum App Android", + "ua" : "Mozilla/5.0 (Linux; Android 11; SM-G970N Build/RP1A.200720.012; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/83.0.4103.106 Mobile Safari/537.36 DaumApps/7.5.0 DaumDevice/mobile", + "expect" : { + "name" : "DaumApps", + "version": "7.5.0", + "major" : "7", + "type" : "inapp" + } + }, + { + "desc" : "Daum App iOS", + "ua" : "Mozilla/5.0 (iPhone; CPU iPhone OS 18_1_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Safari/605.1.15 Mobile/15E148 DaumApps/7.5.1 DaumDevice/mobile", + "expect" : { + "name" : "DaumApps", + "version": "7.5.1", + "major" : "7", + "type" : "inapp" + } + }, { "desc" : "TikTok", "ua" : "Mozilla/5.0 (Linux; Android 11; 21061119AG Build/RP1A.200720.011; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/92.0.4515.131 Mobile Safari/537.36 trill_2022109040 JsSdk/1.0 NetType/MOBILE Channel/googleplay AppName/musical_ly app_version/21.9.4 ByteLocale/ru-RU ByteFullLocale/ru-RU Region/KG BytedanceWebview/d8a21c6", From 46ed9725a7d975c7e10e51b7a881a1fa18ff263c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?helen=2Eone=28=E1=84=80=E1=85=A1=E1=86=BC=E1=84=92?= =?UTF-8?q?=E1=85=A8=E1=84=8B=E1=85=AF=E1=86=AB=29/kakao?= Date: Thu, 12 Dec 2024 17:57:15 +0900 Subject: [PATCH 2/4] Add Daum app user agent --- src/enums/ua-parser-enums.mjs | 1 - src/main/ua-parser.mjs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/enums/ua-parser-enums.mjs b/src/enums/ua-parser-enums.mjs index 210139867..276b8a268 100644 --- a/src/enums/ua-parser-enums.mjs +++ b/src/enums/ua-parser-enums.mjs @@ -38,7 +38,6 @@ const Browser = Object.freeze({ COBALT: 'Cobalt', COC_COC: 'Coc Coc', CONKEROR: 'Conkeror', - DAUM: 'Daum', DILLO: 'Dillo', DOLPHIN: 'Dolphin', DORIS: 'Doris', diff --git a/src/main/ua-parser.mjs b/src/main/ua-parser.mjs index a4ccee30e..09dbce366 100644 --- a/src/main/ua-parser.mjs +++ b/src/main/ua-parser.mjs @@ -401,7 +401,6 @@ /(Klarna)\/([\w\.]+)/i, // Klarna Shopping Browser for iOS & Android /(kakao(?:talk|story))[\/ ]([\w\.]+)/i, // Kakao App /(naver)\(.*?(\d+\.[\w\.]+).*\)/i, // Naver InApp - /(daumapps)[\/ ]([\w\.]+)/i, // Daum App /safari (line)\/([\w\.]+)/i, // Line App for iOS /\b(line)\/([\w\.]+)\/iab/i, // Line App for Android /(alipay)client\/([\w\.]+)/i, // Alipay From 56e5813f5bb1f16efa57774266a8457af0f17fea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?helen=2Eone=28=E1=84=80=E1=85=A1=E1=86=BC=E1=84=92?= =?UTF-8?q?=E1=85=A8=E1=84=8B=E1=85=AF=E1=86=AB=29/kakao?= Date: Thu, 12 Dec 2024 20:16:29 +0900 Subject: [PATCH 3/4] Update Daum app pattern --- src/main/ua-parser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js index 7585a557d..05a5c419a 100755 --- a/src/main/ua-parser.js +++ b/src/main/ua-parser.js @@ -420,7 +420,7 @@ /(Klarna)\/([\w\.]+)/i, // Klarna Shopping Browser for iOS & Android /(kakao(?:talk|story))[\/ ]([\w\.]+)/i, // Kakao App /(naver)\(.*?(\d+\.[\w\.]+).*\)/i, // Naver InApp - /(daumapps)[\/ ]([\w\.]+)/i, // Daum App + /(daum)apps[\/ ]([\w\.]+)/i, // Daum App /safari (line)\/([\w\.]+)/i, // Line App for iOS /\b(line)\/([\w\.]+)\/iab/i, // Line App for Android /(alipay)client\/([\w\.]+)/i, // Alipay From 0692f179b706bf95e7c6ed32a347e3dae08d0d14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?helen=2Eone=28=E1=84=80=E1=85=A1=E1=86=BC=E1=84=92?= =?UTF-8?q?=E1=85=A8=E1=84=8B=E1=85=AF=E1=86=AB=29/kakao?= Date: Thu, 12 Dec 2024 21:01:33 +0900 Subject: [PATCH 4/4] Update Daum app pattern --- test/data/ua/browser/browser-all.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/data/ua/browser/browser-all.json b/test/data/ua/browser/browser-all.json index 00a3349c2..05dfd4fce 100644 --- a/test/data/ua/browser/browser-all.json +++ b/test/data/ua/browser/browser-all.json @@ -2507,7 +2507,7 @@ "desc" : "Daum App Android", "ua" : "Mozilla/5.0 (Linux; Android 11; SM-G970N Build/RP1A.200720.012; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/83.0.4103.106 Mobile Safari/537.36 DaumApps/7.5.0 DaumDevice/mobile", "expect" : { - "name" : "DaumApps", + "name" : "Daum", "version": "7.5.0", "major" : "7", "type" : "inapp" @@ -2517,7 +2517,7 @@ "desc" : "Daum App iOS", "ua" : "Mozilla/5.0 (iPhone; CPU iPhone OS 18_1_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Safari/605.1.15 Mobile/15E148 DaumApps/7.5.1 DaumDevice/mobile", "expect" : { - "name" : "DaumApps", + "name" : "Daum", "version": "7.5.1", "major" : "7", "type" : "inapp"