F-Droid can't build

[licaon-kter]

there's a lot of GMS and Firebase and Crashlytics that need to be cleaned

can't they be separated ?

[fbarthelery]

What's your build issue ?

GMS, Firebase and Crashlytics are used in the google variant that is published on the Play Store. They are not included in the Free variant that you build so they should not be an issue

[licaon-kter]

The fdroid scanner detects them: https://gitlab.com/fdroid/fdroiddata/-/jobs/11546177565#L265

Tried to cleaned up but I messed it up lol https://gitlab.com/fdroid/fdroiddata/-/merge_requests/27230/diffs?commit_id=ca6c186b2a7688066370b83fe3ee2d6a49d627b0

[fbarthelery]

I looked at your changes.

If you change the repository to https://github.com/fbarthelery/geekttrss.git you won't be able to reproduce the same build as I published because the repository commit id get included in the apk.

Regarding the scanner, it seems to be able to scan the apk file. I think this is going to be more reliable than scanning the build.gradle files. I don't think it would be easy to "clean" the build files and remove all references to GMS, Firebase and Crashlytics. Well at least not using sed.

[licaon-kter]

If you change the repository to https://github.com/fbarthelery/geekttrss.git you won't be able to reproduce the same build as I published because the repository commit id get included in the apk.

we no longer support mercurial and subversion

[licaon-kter]

you won't be able to reproduce the same build as I published because the repository commit id get included in the apk.

yeah

│ │ │   --- geekttrss-1.6.9-free-release/smali/T4/e.smali
│ │ ├── +++ com.geekorum.ttrss.free_1069000/smali/T4/e.smali
│ │ │ @@ -348,15 +348,15 @@
│ │ │      if-nez v2, :cond_c
│ │ │  
│ │ │      iput-object v0, v1, Landroidx/preference/Preference;->n:Ljava/lang/CharSequence;
│ │ │  
│ │ │      invoke-virtual {v1}, Landroidx/preference/Preference;->h()V
│ │ │  
│ │ │      :cond_c
│ │ │ -    const-string v0, "hg:8354299fe1553fb423d90d527e096ab5cb927f8c"
│ │ │ +    const-string v0, "unknown"
│ │ │  
│ │ │      const-string v2, "release"
│ │ │  
│ │ │      filled-new-array {v0, v2}, [Ljava/lang/Object;
│ │ │  
│ │ │      move-result-object v0

any reason for that? can this be cleaned up?

[fbarthelery]

It's a valuable tools to identify a pre release precisely. I guess I can set it to an empty string on a release build as they are tagged.