fix(softDelete): use _patch for softDelete (#9)

* fix(softDelete): use _patch for softDelete

* fix: use addToQuery for softDelete

Author: fratzinger

src/hooks/cache/cache.hook.ts

@@ -47,7 +47,7 @@ export const cache = <H extends HookContext = HookContext>(
       await cacheBefore(context, cacheMap)
       await next()
       await cacheAfter(context, cacheMap)
-      return context
+      return
     }
   }
 }

src/hooks/check-required/check-required.hook.ts

@@ -44,6 +44,6 @@ export function checkRequired<H extends HookContext = HookContext>(
       }
     }
 
-    if (next) return next().then(() => context)
+    if (next) return next()
   }
 }

src/hooks/create-related/create-related.hook.ts

@@ -53,7 +53,5 @@ export function createRelated<
         }
       }),
     )
-
-    return context
   }
 }

src/hooks/disable-pagination/disable-pagination.hook.test.ts

@@ -1,44 +1,61 @@
 import { assert } from 'vitest'
 import { disablePagination } from './disable-pagination.hook.js'
+import type { HookContext } from '@feathersjs/feathers'
 
-let hookBefore: any
-
-describe('services disablePagination', () => {
-  beforeEach(() => {
-    hookBefore = {
+describe('hook - disablePagination', () => {
+  it('disables on $limit = -1', () => {
+    const result: any = disablePagination()({
       type: 'before',
       method: 'find',
       params: { query: { id: 1, $limit: -1 } },
-    }
+    } as HookContext)
+    assert.deepEqual(result.params, { paginate: false, query: { id: 1 } })
   })
 
-  it('disables on $limit = -1', () => {
-    hookBefore.params.query.$limit = -1
-
-    const result: any = disablePagination()(hookBefore)
+  it('disables on $limit = "-1"', () => {
+    const result: any = disablePagination()({
+      type: 'before',
+      method: 'find',
+      params: { query: { id: 1, $limit: '-1' } },
+    } as HookContext)
     assert.deepEqual(result.params, { paginate: false, query: { id: 1 } })
   })
 
-  it('disables on $limit = "-1"', () => {
-    hookBefore.params.query.$limit = '-1'
+  it('disables on $limit = -1 in around', () => {
+    const result: any = disablePagination()({
+      type: 'around',
+      method: 'find',
+      params: { query: { id: 1, $limit: -1 } },
+    } as HookContext)
+    assert.deepEqual(result.params, { paginate: false, query: { id: 1 } })
+  })
 
-    const result: any = disablePagination()(hookBefore)
+  it('disables on $limit = "-1" in around', () => {
+    const result: any = disablePagination()({
+      type: 'around',
+      method: 'find',
+      params: { query: { id: 1, $limit: '-1' } },
+    } as HookContext)
     assert.deepEqual(result.params, { paginate: false, query: { id: 1 } })
   })
 
   it('throws if after hook', () => {
-    hookBefore.type = 'after'
-
     assert.throws(() => {
-      disablePagination()(hookBefore)
+      disablePagination()({
+        type: 'after',
+        method: 'find',
+        params: { query: { id: 1, $limit: -1 } },
+      } as HookContext)
     })
   })
 
   it('throws if not find', () => {
-    hookBefore.method = 'get'
-
     assert.throws(() => {
-      disablePagination()(hookBefore)
+      disablePagination()({
+        type: 'before',
+        method: 'get',
+        params: { query: { id: 1, $limit: -1 } },
+      } as HookContext)
     })
   })
 })

src/hooks/disable-pagination/disable-pagination.hook.ts

@@ -9,15 +9,15 @@ import { checkContext } from '../../utils/index.js'
 export const disablePagination =
   <H extends HookContext = HookContext>() =>
   (context: H, next?: NextFunction) => {
-    checkContext(context, 'before', ['find'], 'disablePagination')
+    checkContext(context, ['before', 'around'], ['find'], 'disablePagination')
     const $limit = context.params?.query?.$limit
 
     if ($limit === '-1' || $limit === -1) {
       context.params.paginate = false
       delete context.params.query.$limit
     }
 
-    if (next) return next().then(() => context)
+    if (next) return next()
 
     return context
   }

src/hooks/disallow/disallow.hook.test.ts

@@ -1,7 +1,7 @@
 import { assert } from 'vitest'
 import { disallow } from './disallow.hook.js'
 
-describe('services disallow', () => {
+describe('hook - disallow', () => {
   describe('disallow is compatible with .disable (without predicate)', () => {
     let hookRest: any
     let hookSocketio: any

src/hooks/on-delete/on-delete.hook.ts

@@ -58,7 +58,7 @@ export const onDelete = <
     const { result } = getResultIsArray(context)
 
     if (!result.length) {
-      return context
+      return
     }
 
     const promises: Promise<any>[] = []
@@ -102,6 +102,6 @@ export const onDelete = <
       await Promise.all(promises)
     }
 
-    return context
+    return
   }
 }