Extended the rules for review-patch.py for files w/o extension

Implement these rules in test code and describe them in comment

Author: christian-intra2net

review-patch.py

@@ -47,10 +47,32 @@ def review_patches(patches):
 
         added_files.sort()
         for f in added_files:
-            dir_id = f.rfind("/") + 1
+            dir_id = f.rfind("/") + 1    # f[dir_id:] is name.type[.source.txt]
+            if dir_id == 0:
+                out += "\tMalformed patch: " + f + " should be of the form 'b/db/type/name.type[.source.txt]'\n"
+                ret = 1
+                local_error = True
+                continue
+            if not "/db/" in f:
+                continue     # file is not in db subdir
+
             ext_id = dir_id + f[dir_id:].find(".")
-            if ext_id != -1:
-                ext = f[ext_id + 1:]
+            if ext_id == dir_id-1:    # check if f is .../db/type/type or .../db/misc/type
+                dir_id2 = f.rfind("/", 0, dir_id-1)+1   # f[dir_id2:dir_id] is subdir within db/
+                if f[dir_id2:dir_id-1] == f[dir_id:]:
+                    pass  #    ok, is .../db/type/type
+                    if f[dir_id2] in ('.', '_'):
+                        out += "\t" + f + ": Subdir names may not start with . or _\n"
+                        ret = 1
+                        local_error = True
+                elif f[dir_id2:dir_id-1] == 'misc':
+                    pass  #    ok, is .../db/msic/type
+                else:
+                    out += "\t" + f + ": File is not in proper directory according to extension\n"
+                    ret = 1
+                    local_error = True
+            else:
+                ext = f[ext_id + 1:]     # ext is type[.source.txt]
                 if ext.endswith("source.txt"):
                     real_db_file = f[:-len(".source.txt")]
                     try:
@@ -87,6 +109,12 @@ def review_patches(patches):
  - Every file with extension '.X' has to be in directory 'db/X' according to
    its extension. Note that case sensitivity is important and must be
    respected.
+ - If a file has no (typical) extension (e.g. AppleDouble), then it has to go
+   to folder db/misc or must be given a descriptive short name and no extension
+   and appear in a directory of the same name (e.g. db/AppleDouble/AppleDouble).
+   The corresponding .source.txt needs to explain this in a line starting with
+   'NOTE: ' (see e.g. db/AppleDouble/AppleDouble.source.txt). No leading . or _
+   (e.g. .DS_Store --> DS_Store)
 """
         print "Usage: " + sys.argv[0] + " [[patch1], [patch2], ...]"
         print "Usage: " + sys.argv[0] + " *.patch"