-
Notifications
You must be signed in to change notification settings - Fork 21
Update dependencies and test code #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update dependencied - Update test code to use equivalents in github.com/ipfs/go-test
353e18f to
472d488
Compare
|
failures all look like the bitswap errors we've been dealing with forever previously solved by using a fork that had this on top of it: ipfs/boxo@894484c but now we're using main releases we don't have that so we just get failures |
|
what's the latest boxo we can use? in singularity we are stuck on quite old (v0.24.3 at the latest) boxo because we also depend on lassie, I'm trying to decide whether to remove the lassie dependency |
|
@parkan you can use a more recent boxo, our tests fail with boxo versions other than the one you're probably using but it may be more indicative of the tight test environment we run than production-level typical bitswap interactions. This PR is probably OK to merge, but for the test failures isolated to bitswap making everything red. Also, bitswap is gone from Filecoin SPs these days so less of an issue I think, I'm not sure who's publishing bitswap records to IPNI? |
|
with boxo v0.25.0 or higher we get: |
|
I'm able to get it building with boxo@v0.35.0 by removing all bitswap code, fixing bsnetwork.NewFromIpfsHost to remove the routing parameter (this probably needs to be actually passed in some other way though) and upgrading go-graphsync to v0.18.0 to me this is actually all fine since bitswap is, as you said, not useful I might vendor this for now so we can bring singularity up to date |
|
quick n dirty version here: main...parkan:lassie:main |
github.com/ipfs/go-testgo.uber.org/multierrwith stdliberrorspackage