Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 5, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Open Files app
  2. Enable the setting to run Files in the background
  3. Start debebugging Files
  4. Close the window
  5. Launch Files from Start Menu

@0x5bfa
Copy link
Member Author

0x5bfa commented May 5, 2025

Requesting your review @dongle-the-gadget @hez2010

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label May 5, 2025
@yaira2 yaira2 requested a review from hez2010 May 5, 2025 14:21
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-RunAsSync branch 2 times, most recently from fc48386 to eca313e Compare May 14, 2025 16:05
@0x5bfa
Copy link
Member Author

0x5bfa commented May 26, 2025

Ready

@yaira2 yaira2 requested a review from dongle-the-gadget June 8, 2025 21:09
@dongle-the-gadget
Copy link
Contributor

I think it's better to do something like

public Task Something(Task task)
{
    async Task Call()
    {
        await task;
        SetEvent();
    }
}

@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 42c8207 to 4c7493f Compare July 6, 2025 15:16
@yaira2
Copy link
Member

yaira2 commented Jul 6, 2025

@0x5bfa fyi

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 7, 2025

@ahmed605 What is your opinion too? I can't be sure the current code and the above code is really non blocking.

@yaira2
Copy link
Member

yaira2 commented Aug 11, 2025

What's the state of this PR?

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-RunAsSync branch from eca313e to fab5674 Compare August 19, 2025 21:35
@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 19, 2025

Committed the requested change. Itested the change in RedirectActivationTo on my local but didn't test the one in OpenFileFromTile as I don't have Windows 10 rn.

PTAL. CC: @ahmed605

@ahmed605
Copy link
Contributor

LGTM

@0x5bfa 0x5bfa changed the title Code Quality: Introduced a wrapper for non-blocking await on a sync method Code Quality: Removed extra code for async ops in Program class Aug 22, 2025
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Sep 3, 2025
@yaira2 yaira2 merged commit bb7a0db into files-community:main Sep 3, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-RunAsSync branch September 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants