From d898c3a31aff4c0c310ac18db7839f44537e24bf Mon Sep 17 00:00:00 2001 From: Kai Bolay Date: Fri, 29 Nov 2024 14:50:00 -0500 Subject: [PATCH 1/4] Log platform if binary not found --- .../actions/firebase_app_distribution_action.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb index 4810c97..66b665a 100644 --- a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb +++ b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb @@ -34,8 +34,8 @@ def self.run(params) timeout = get_upload_timeout(params) binary_path = get_binary_path(platform, params) - UI.user_error!("Couldn't find binary.") if binary_path.nil? - UI.user_error!("Couldn't find binary at path #{binary_path}.") unless File.exist?(binary_path) + UI.user_error!("Couldn't find #{platform} binary.") if binary_path.nil? + UI.user_error!("Couldn't find #{platform} binary at path #{binary_path}.") unless File.exist?(binary_path) binary_type = binary_type_from_path(binary_path) # TODO(lkellogg): This sets the send timeout for all POST requests made by the client, but From f00fd839195d04e458f09cf3ea17b8b32eaf5be1 Mon Sep 17 00:00:00 2001 From: Kai Bolay Date: Fri, 29 Nov 2024 19:57:12 +0000 Subject: [PATCH 2/4] fix test --- spec/firebase_app_distribution_action_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/firebase_app_distribution_action_spec.rb b/spec/firebase_app_distribution_action_spec.rb index a897188..aadda15 100644 --- a/spec/firebase_app_distribution_action_spec.rb +++ b/spec/firebase_app_distribution_action_spec.rb @@ -229,13 +229,13 @@ it 'raises error if it cannot find a valid binary path' do expect do action.run(params.merge(ipa_path: nil)) - end.to raise_error("Couldn't find binary.") + end.to raise_error("Couldn't find ios binary.") end it 'raises error if binary does not exist' do expect do action.run(params) - end.to raise_error("Couldn't find binary at path debug.ipa.") + end.to raise_error("Couldn't find ios binary at path debug.ipa.") end describe 'with android app' do From 97c06dab4962ab5a7b65571452207056f4d4a075 Mon Sep 17 00:00:00 2001 From: Kai Bolay Date: Sat, 30 Nov 2024 15:56:31 +0000 Subject: [PATCH 3/4] disambiguate error message --- .../actions/firebase_app_distribution_action.rb | 2 +- spec/firebase_app_distribution_action_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb index 66b665a..797b373 100644 --- a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb +++ b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb @@ -34,7 +34,7 @@ def self.run(params) timeout = get_upload_timeout(params) binary_path = get_binary_path(platform, params) - UI.user_error!("Couldn't find #{platform} binary.") if binary_path.nil? + UI.user_error!("Couldn't find path for #{platform} binary.") if binary_path.nil? UI.user_error!("Couldn't find #{platform} binary at path #{binary_path}.") unless File.exist?(binary_path) binary_type = binary_type_from_path(binary_path) diff --git a/spec/firebase_app_distribution_action_spec.rb b/spec/firebase_app_distribution_action_spec.rb index aadda15..0edc68e 100644 --- a/spec/firebase_app_distribution_action_spec.rb +++ b/spec/firebase_app_distribution_action_spec.rb @@ -229,7 +229,7 @@ it 'raises error if it cannot find a valid binary path' do expect do action.run(params.merge(ipa_path: nil)) - end.to raise_error("Couldn't find ios binary.") + end.to raise_error("Couldn't find path for ios binary.") end it 'raises error if binary does not exist' do From 6aca8155efc2478637cbbcebbd4ca00c762b1c0d Mon Sep 17 00:00:00 2001 From: Kai Bolay Date: Sat, 30 Nov 2024 16:01:36 +0000 Subject: [PATCH 4/4] further clarify error message --- .../actions/firebase_app_distribution_action.rb | 2 +- spec/firebase_app_distribution_action_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb index 797b373..e70395e 100644 --- a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb +++ b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb @@ -34,7 +34,7 @@ def self.run(params) timeout = get_upload_timeout(params) binary_path = get_binary_path(platform, params) - UI.user_error!("Couldn't find path for #{platform} binary.") if binary_path.nil? + UI.user_error!("Couldn't determine path for #{platform} binary.") if binary_path.nil? UI.user_error!("Couldn't find #{platform} binary at path #{binary_path}.") unless File.exist?(binary_path) binary_type = binary_type_from_path(binary_path) diff --git a/spec/firebase_app_distribution_action_spec.rb b/spec/firebase_app_distribution_action_spec.rb index 0edc68e..1beb5f8 100644 --- a/spec/firebase_app_distribution_action_spec.rb +++ b/spec/firebase_app_distribution_action_spec.rb @@ -226,10 +226,10 @@ allow(action).to receive(:get_authorization).and_return(double('authorization', access_token: 'access-token')) end - it 'raises error if it cannot find a valid binary path' do + it 'raises error if it cannot determine a valid binary path' do expect do action.run(params.merge(ipa_path: nil)) - end.to raise_error("Couldn't find path for ios binary.") + end.to raise_error("Couldn't determine path for ios binary.") end it 'raises error if binary does not exist' do