Merge pull request #1240 from firebase/@invertase/bb-26

Author: Ehesp

examples/shadcn/src/components/sign-in-auth-form.tsx

@@ -80,7 +80,7 @@ export function SignInAuthForm(props: SignInAuthFormProps) {
         {props.onRegisterClick ? (
           <>
             <Button type="button" variant="secondary" onClick={props.onRegisterClick}>
-              {getTranslation(ui, "prompts", "noAccount")} {getTranslation(ui, "labels", "register")}
+              {getTranslation(ui, "prompts", "noAccount")} {getTranslation(ui, "labels", "signUp")}
             </Button>
           </>
         ) : null}

examples/shadcn/src/components/sign-up-auth-screen.tsx

@@ -12,7 +12,7 @@ export type { SignUpAuthScreenProps };
 export function SignUpAuthScreen({ children, ...props }: SignUpAuthScreenProps) {
   const ui = useUI();
 
-  const titleText = getTranslation(ui, "labels", "register");
+  const titleText = getTranslation(ui, "labels", "signUp");
   const subtitleText = getTranslation(ui, "prompts", "enterDetailsToCreate");
 
   return (

packages/angular/src/lib/auth/forms/sign-in-auth-form.spec.ts

@@ -78,7 +78,7 @@ describe("<fui-sign-in-auth-form />", () => {
     expect(screen.getByRole("button", { name: "Sign In" })).toBeInTheDocument();
     expect(screen.getByText("By continuing, you agree to our")).toBeInTheDocument();
     expect(screen.getByRole("button", { name: "Forgot Password" })).toBeInTheDocument();
-    expect(screen.getByRole("button", { name: "Don't have an account? Register" })).toBeInTheDocument();
+    expect(screen.getByRole("button", { name: "Don't have an account? Sign Up" })).toBeInTheDocument();
   });
 
   it("should have correct translation labels", async () => {
@@ -102,7 +102,7 @@ describe("<fui-sign-in-auth-form />", () => {
     expect(component.forgotPasswordLabel()).toBe("Forgot Password");
     expect(component.signInLabel()).toBe("Sign In");
     expect(component.noAccountLabel()).toBe("Don't have an account?");
-    expect(component.registerLabel()).toBe("Register");
+    expect(component.signUpLabel()).toBe("Sign Up");
     expect(component.unknownErrorLabel()).toBe("An unknown error occurred");
   });
 
@@ -164,7 +164,7 @@ describe("<fui-sign-in-auth-form />", () => {
     const component = fixture.componentInstance;
     const signUpSpy = jest.spyOn(component.signUp, "emit");
 
-    const signUpButton = screen.getByRole("button", { name: "Don't have an account? Register" });
+    const signUpButton = screen.getByRole("button", { name: "Don't have an account? Sign Up" });
     fireEvent.click(signUpButton);
     expect(signUpSpy).toHaveBeenCalled();
   });

packages/angular/src/lib/auth/forms/sign-in-auth-form.ts

@@ -72,7 +72,7 @@ import {
       </fieldset>
 
       @if (signUp) {
-        <button fui-form-action (click)="signUp.emit()">{{ noAccountLabel() }} {{ registerLabel() }}</button>
+        <button fui-form-action (click)="signUp.emit()">{{ noAccountLabel() }} {{ signUpLabel() }}</button>
       }
     </form>
   `,
@@ -86,7 +86,7 @@ export class SignInAuthFormComponent {
   forgotPasswordLabel = injectTranslation("labels", "forgotPassword");
   signInLabel = injectTranslation("labels", "signIn");
   noAccountLabel = injectTranslation("prompts", "noAccount");
-  registerLabel = injectTranslation("labels", "register");
+  signUpLabel = injectTranslation("labels", "signUp");
   unknownErrorLabel = injectTranslation("errors", "unknownError");
 
   forgotPassword = output<void>();

packages/angular/src/lib/auth/screens/sign-up-auth-screen.spec.ts

@@ -73,7 +73,7 @@ describe("<fui-sign-up-auth-screen>", () => {
     injectTranslation.mockImplementation((category: string, key: string) => {
       const mockTranslations: Record<string, Record<string, string>> = {
         labels: {
-          register: "Create Account",
+          signUp: "Create Account",
         },
         prompts: {
           enterDetailsToCreate: "Enter your details to create an account",
@@ -205,7 +205,7 @@ describe("<fui-sign-up-auth-screen>", () => {
       ],
     });
 
-    expect(injectTranslation).toHaveBeenCalledWith("labels", "register");
+    expect(injectTranslation).toHaveBeenCalledWith("labels", "signUp");
     expect(injectTranslation).toHaveBeenCalledWith("prompts", "enterDetailsToCreate");
   });
 

packages/angular/src/lib/auth/screens/sign-up-auth-screen.ts

@@ -69,7 +69,7 @@ export class SignUpAuthScreenComponent {
 
   mfaResolver = computed(() => this.ui().multiFactorResolver);
 
-  titleText = injectTranslation("labels", "register");
+  titleText = injectTranslation("labels", "signUp");
   subtitleText = injectTranslation("prompts", "enterDetailsToCreate");
 
   signUp = output<UserCredential>();

packages/angular/src/lib/tests/test-helpers.ts

@@ -75,7 +75,6 @@ export const injectUI = jest.fn().mockReturnValue(() => ({
         sendSignInLink: "Send Sign In Link",
         resetPassword: "Reset Password",
         backToSignIn: "Back to Sign In",
-        register: "Register",
         termsOfService: "Terms of Service",
         privacyPolicy: "Privacy Policy",
       },
@@ -109,7 +108,6 @@ export const injectTranslation = jest.fn().mockImplementation((category: string,
       sendSignInLink: "Send Sign In Link",
       resetPassword: "Reset Password",
       backToSignIn: "Back to Sign In",
-      register: "Register",
       termsOfService: "Terms of Service",
       privacyPolicy: "Privacy Policy",
       phoneNumber: "Phone Number",

packages/react/src/auth/forms/sign-in-auth-form.test.tsx

@@ -236,7 +236,7 @@ describe("<SignInAuthForm />", () => {
           noAccount: "foo",
         },
         labels: {
-          register: "bar",
+          signUp: "bar",
         },
       }),
     });

packages/react/src/auth/forms/sign-in-auth-form.tsx

@@ -112,7 +112,7 @@ export function SignInAuthForm({ onSignIn, onForgotPasswordClick, onRegisterClic
         </fieldset>
         {onRegisterClick ? (
           <form.Action onClick={onRegisterClick}>
-            {getTranslation(ui, "prompts", "noAccount")} {getTranslation(ui, "labels", "register")}
+            {getTranslation(ui, "prompts", "noAccount")} {getTranslation(ui, "labels", "signUp")}
           </form.Action>
         ) : null}
       </form.AppForm>

packages/react/src/auth/screens/sign-up-auth-screen.test.tsx

@@ -59,7 +59,7 @@ describe("<SignUpAuthScreen />", () => {
     const ui = createMockUI({
       locale: registerLocale("test", {
         labels: {
-          register: "register",
+          signUp: "register",
         },
         prompts: {
           enterDetailsToCreate: "enterDetailsToCreate",