chore: Cleanup tests

Ehesp · Ehesp · commit e52ee10afb78 · 2025-10-29T09:07:00.000Z
diff --git a/packages/angular/src/lib/auth/forms/email-link-auth-form.spec.ts b/packages/angular/src/lib/auth/forms/email-link-auth-form.spec.ts
@@ -309,7 +309,6 @@ describe("<fui-email-link-auth-form />", () => {
       ],
     });
 
-    // Wait for the async completeSignIn to be called
     await waitFor(() => {
       expect(mockCompleteEmailLinkSignIn).toHaveBeenCalledWith(
         expect.objectContaining({
diff --git a/packages/angular/src/lib/auth/forms/forgot-password-auth-form.spec.ts b/packages/angular/src/lib/auth/forms/forgot-password-auth-form.spec.ts
@@ -277,13 +277,11 @@ describe("<fui-forgot-password-auth-form />", () => {
     component.form.setFieldValue("email", "nonexistent@example.com");
     fixture.detectChanges();
 
-    // Trigger form submission
     await component.form.handleSubmit();
     await fixture.whenStable();
     fixture.detectChanges();
 
     expect(component.emailSent()).toBe(false);
-    // The error should be in the form state
     expect(component.form.state.errors.length).toBeGreaterThan(0);
   });
 
@@ -309,13 +307,11 @@ describe("<fui-forgot-password-auth-form />", () => {
     component.form.setFieldValue("email", "test@example.com");
     fixture.detectChanges();
 
-    // Trigger form submission
     await component.form.handleSubmit();
     await fixture.whenStable();
     fixture.detectChanges();
 
     expect(component.emailSent()).toBe(false);
-    // The error should be in the form state
     expect(component.form.state.errors.length).toBeGreaterThan(0);
   });
 
@@ -344,7 +340,6 @@ describe("<fui-forgot-password-auth-form />", () => {
     component.form.setFieldValue("email", "test@example.com");
     fixture.detectChanges();
 
-    // Should have no errors now
     expect(component.form.state.errors).toHaveLength(0);
   });
 });
diff --git a/packages/angular/src/lib/auth/forms/mfa/sms-multi-factor-assertion-form.spec.ts b/packages/angular/src/lib/auth/forms/mfa/sms-multi-factor-assertion-form.spec.ts
@@ -71,11 +71,9 @@ describe("<fui-sms-multi-factor-assertion-form>", () => {
       });
     });
 
-    // Mock FirebaseUI Core functions
     verifyPhoneNumber.mockResolvedValue("test-verification-id");
     signInWithMultiFactorAssertion.mockResolvedValue({});
 
-    // Mock Firebase Auth classes
     const { PhoneAuthProvider, PhoneMultiFactorGenerator } = require("firebase/auth");
     PhoneAuthProvider.credential = jest.fn().mockReturnValue({});
     PhoneMultiFactorGenerator.assertion = jest.fn().mockReturnValue({});
@@ -107,20 +105,17 @@ describe("<fui-sms-multi-factor-assertion-form>", () => {
       phoneNumber: "+1234567890",
     };
 
-    const { fixture } = await render(SmsMultiFactorAssertionFormComponent, {
+    await render(SmsMultiFactorAssertionFormComponent, {
       componentInputs: {
         hint: mockHint,
       },
       imports: [SmsMultiFactorAssertionFormComponent],
     });
 
-    // Initially shows phone form
     expect(screen.getByLabelText("Phone Number")).toBeInTheDocument();
 
-    // Submit the phone form
     fireEvent.click(screen.getByRole("button", { name: "Send Code" }));
 
-    // Wait for the form to switch
     await waitFor(() => {
       expect(screen.getByLabelText("Verification Code")).toBeInTheDocument();
     });
@@ -146,7 +141,6 @@ describe("<fui-sms-multi-factor-assertion-form>", () => {
     const onSuccessSpy = jest.fn();
     fixture.componentInstance.onSuccess.subscribe(onSuccessSpy);
 
-    // Submit phone form to get to verification form
     const phoneFormComponent = fixture.debugElement.query(
       (el) => el.componentInstance?.constructor?.name === "SmsMultiFactorAssertionPhoneFormComponent"
     )?.componentInstance;
@@ -160,7 +154,6 @@ describe("<fui-sms-multi-factor-assertion-form>", () => {
       expect(screen.getByLabelText("Verification Code")).toBeInTheDocument();
     });
 
-    // Fill in verification code and submit
     const verifyFormComponent = fixture.debugElement.query(
       (el) => el.componentInstance?.constructor?.name === "SmsMultiFactorAssertionVerifyFormComponent"
     )?.componentInstance;
@@ -169,6 +162,8 @@ describe("<fui-sms-multi-factor-assertion-form>", () => {
       verifyFormComponent.form.setFieldValue("verificationCode", "123456");
       verifyFormComponent.form.setFieldValue("verificationId", "test-verification-id");
       await verifyFormComponent.form.handleSubmit();
+    } else {
+      fail("Verify form component not found");
     }
 
     await waitFor(() => {
@@ -211,7 +206,6 @@ describe("<fui-sms-multi-factor-assertion-phone-form>", () => {
       });
     });
 
-    // Mock FirebaseUI Core functions
     verifyPhoneNumber.mockResolvedValue("test-verification-id");
   });
 
@@ -293,10 +287,8 @@ describe("<fui-sms-multi-factor-assertion-verify-form>", () => {
       });
     });
 
-    // Mock FirebaseUI Core functions
     signInWithMultiFactorAssertion.mockResolvedValue({});
 
-    // Mock Firebase Auth classes
     const { PhoneAuthProvider, PhoneMultiFactorGenerator } = require("firebase/auth");
     PhoneAuthProvider.credential = jest.fn().mockReturnValue({});
     PhoneMultiFactorGenerator.assertion = jest.fn().mockReturnValue({});
@@ -325,7 +317,6 @@ describe("<fui-sms-multi-factor-assertion-verify-form>", () => {
     const onSuccessSpy = jest.fn();
     fixture.componentInstance.onSuccess.subscribe(onSuccessSpy);
 
-    // Fill in verification code and submit
     const component = fixture.componentInstance;
     component.form.setFieldValue("verificationCode", "123456");
     component.form.setFieldValue("verificationId", "test-verification-id");
diff --git a/packages/angular/src/lib/auth/forms/mfa/sms-multi-factor-enrollment-form.spec.ts b/packages/angular/src/lib/auth/forms/mfa/sms-multi-factor-enrollment-form.spec.ts
@@ -53,7 +53,6 @@ describe("<fui-sms-multi-factor-enrollment-form />", () => {
     mockPhoneAuthProvider = PhoneAuthProvider;
     mockPhoneMultiFactorGenerator = PhoneMultiFactorGenerator;
 
-    // Mock provider functions
     injectTranslation.mockImplementation((category: string, key: string) => {
       const mockTranslations: Record<string, Record<string, string>> = {
         labels: {
@@ -328,7 +327,6 @@ describe("<fui-sms-multi-factor-enrollment-form />", () => {
   });
 
   it("should throw error if user is not authenticated", async () => {
-    // Override the injectUI mock for this test
     const { injectUI } = require("../../../tests/test-helpers");
     injectUI.mockImplementation(() => {
       return () => ({
diff --git a/packages/angular/src/lib/auth/forms/mfa/totp-multi-factor-assertion-form.spec.ts b/packages/angular/src/lib/auth/forms/mfa/totp-multi-factor-assertion-form.spec.ts
@@ -13,11 +13,9 @@
  * limitations under the License.
  */
 
-import { render, screen, fireEvent, waitFor } from "@testing-library/angular";
-import { TotpMultiFactorGenerator } from "firebase/auth";
+import { render, screen } from "@testing-library/angular";
 
 import { TotpMultiFactorAssertionFormComponent } from "./totp-multi-factor-assertion-form";
-
 import { signInWithMultiFactorAssertion, FirebaseUIError } from "../../../tests/test-helpers";
 
 describe("<fui-totp-multi-factor-assertion-form>", () => {
@@ -58,14 +56,11 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
       });
     });
 
-    // Mock FirebaseUI Core functions
     signInWithMultiFactorAssertion.mockResolvedValue({});
 
-    // Mock Firebase Auth classes
     TotpMultiFactorGenerator = require("firebase/auth").TotpMultiFactorGenerator;
     TotpMultiFactorGenerator.assertionForSignIn = jest.fn().mockReturnValue({});
 
-    // Clear all mocks before each test
     jest.clearAllMocks();
   });
 
@@ -102,7 +97,7 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
       imports: [TotpMultiFactorAssertionFormComponent],
     });
 
-    // Check that the form input component has the placeholder attribute
+    // Verify the verification code input field starts empty (no pre-filled value)
     const formInput = screen.getByDisplayValue("");
     expect(formInput).toBeInTheDocument();
   });
@@ -125,7 +120,6 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
     const onSuccessSpy = jest.fn();
     component.onSuccess.subscribe(onSuccessSpy);
 
-    // Set form values and submit directly
     component.form.setFieldValue("verificationCode", "123456");
     fixture.detectChanges();
 
@@ -153,7 +147,6 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
 
     const component = fixture.componentInstance;
 
-    // Set form values and submit directly
     component.form.setFieldValue("verificationCode", "123456");
     fixture.detectChanges();
 
@@ -182,7 +175,6 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
 
     const component = fixture.componentInstance;
 
-    // Set form values and submit directly
     component.form.setFieldValue("verificationCode", "123456");
     fixture.detectChanges();
 
@@ -214,7 +206,6 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
 
     const component = fixture.componentInstance;
 
-    // Set form values and submit directly
     component.form.setFieldValue("verificationCode", "123456");
     fixture.detectChanges();
 
@@ -243,7 +234,6 @@ describe("<fui-totp-multi-factor-assertion-form>", () => {
 
     const component = fixture.componentInstance;
 
-    // Set form values and submit directly
     component.form.setFieldValue("verificationCode", "123456");
     fixture.detectChanges();
 
diff --git a/packages/angular/src/lib/auth/forms/mfa/totp-multi-factor-enrollment-form.spec.ts b/packages/angular/src/lib/auth/forms/mfa/totp-multi-factor-enrollment-form.spec.ts
@@ -47,7 +47,6 @@ describe("<fui-totp-multi-factor-enrollment-form />", () => {
     mockFirebaseUIError = FirebaseUIError;
     mockTotpMultiFactorGenerator = TotpMultiFactorGenerator;
 
-    // Mock provider functions
     injectTranslation.mockImplementation((category: string, key: string) => {
       const mockTranslations: Record<string, Record<string, string>> = {
         labels: {
@@ -302,7 +301,6 @@ describe("<fui-totp-multi-factor-enrollment-form />", () => {
   });
 
   it("should throw error if user is not authenticated", async () => {
-    // Override the injectUI mock for this test
     const { injectUI } = require("../../../tests/test-helpers");
     injectUI.mockImplementation(() => {
       return () => ({
diff --git a/packages/angular/src/lib/auth/forms/multi-factor-auth-assertion-form.spec.ts b/packages/angular/src/lib/auth/forms/multi-factor-auth-assertion-form.spec.ts
@@ -112,7 +112,6 @@ describe("<fui-multi-factor-auth-assertion-form>", () => {
   });
 
   it("switches to assertion form when selection button is clicked", async () => {
-    // Override the inner components with mocks
     TestBed.overrideComponent(SmsMultiFactorAssertionFormComponent, {
       set: {
         template: '<div data-testid="sms-assertion-form">SMS Assertion Form</div>',
diff --git a/packages/angular/src/lib/auth/forms/multi-factor-auth-enrollment-form.spec.ts b/packages/angular/src/lib/auth/forms/multi-factor-auth-enrollment-form.spec.ts
@@ -68,11 +68,9 @@ describe("<fui-multi-factor-auth-enrollment-form />", () => {
       },
     });
 
-    // Should not show selection buttons
     expect(screen.queryByRole("button", { name: "SMS Verification" })).not.toBeInTheDocument();
     expect(screen.queryByRole("button", { name: "TOTP Verification" })).not.toBeInTheDocument();
 
-    // Should show SMS form directly
     expect(screen.getByLabelText("Display Name")).toBeInTheDocument();
     expect(screen.getByLabelText("Phone Number")).toBeInTheDocument();
   });
@@ -139,7 +137,6 @@ describe("<fui-multi-factor-auth-enrollment-form />", () => {
     const component = fixture.componentInstance;
     const enrollmentSpy = jest.spyOn(component.onEnrollment, "emit");
 
-    // Get the SMS form component and emit enrollment
     const smsFormComponent = fixture.debugElement.query(
       (el) => el.componentInstance instanceof SmsMultiFactorEnrollmentFormComponent
     )?.componentInstance as SmsMultiFactorEnrollmentFormComponent;
@@ -167,7 +164,6 @@ describe("<fui-multi-factor-auth-enrollment-form />", () => {
     const component = fixture.componentInstance;
     const enrollmentSpy = jest.spyOn(component.onEnrollment, "emit");
 
-    // Get the TOTP form component and emit enrollment
     const totpFormComponent = fixture.debugElement.query(
       (el) => el.componentInstance instanceof TotpMultiFactorEnrollmentFormComponent
     )?.componentInstance as TotpMultiFactorEnrollmentFormComponent;
diff --git a/packages/angular/src/lib/auth/forms/sign-up-auth-form.spec.ts b/packages/angular/src/lib/auth/forms/sign-up-auth-form.spec.ts
@@ -151,7 +151,6 @@ describe("<fui-sign-up-auth-form />", () => {
     const component = fixture.componentInstance;
     expect(component.form.getFieldValue("email")).toBe("");
     expect(component.form.getFieldValue("password")).toBe("");
-    // displayName is undefined when hasBehavior returns false
     expect(component.form.getFieldValue("displayName")).toBeUndefined();
   });
 
diff --git a/packages/angular/src/lib/auth/oauth/apple-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/apple-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component } from "@angular/core";
 
 import { AppleSignInButtonComponent } from "./apple-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-apple-sign-in-button></fui-apple-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/oauth/facebook-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/facebook-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component } from "@angular/core";
 
 import { FacebookSignInButtonComponent } from "./facebook-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-facebook-sign-in-button></fui-facebook-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/oauth/github-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/github-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component } from "@angular/core";
 
 import { GithubSignInButtonComponent } from "./github-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-github-sign-in-button></fui-github-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/oauth/google-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/google-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component, signal } from "@angular/core";
 
 import { GoogleSignInButtonComponent } from "./google-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-google-sign-in-button></fui-google-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/oauth/microsoft-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/microsoft-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component } from "@angular/core";
 
 import { MicrosoftSignInButtonComponent } from "./microsoft-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-microsoft-sign-in-button></fui-microsoft-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/oauth/oauth-button.spec.ts b/packages/angular/src/lib/auth/oauth/oauth-button.spec.ts
@@ -17,11 +17,8 @@
 import { render, screen, fireEvent, waitFor } from "@testing-library/angular";
 import { Component } from "@angular/core";
 import { OAuthButtonComponent } from "./oauth-button";
-// ButtonComponent is imported by OAuthButtonComponent
 import { AuthProvider } from "@angular/fire/auth";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: ` <fui-oauth-button [provider]="provider"> Sign in with Google </fui-oauth-button> `,
   standalone: true,
@@ -49,7 +46,6 @@ describe("<fui-oauth-button>", () => {
     mockSignInWithProvider = signInWithProvider;
     mockFirebaseUIError = FirebaseUIError;
 
-    // Reset mocks
     mockSignInWithProvider.mockClear();
   });
 
@@ -154,22 +150,21 @@ describe("<fui-oauth-button>", () => {
   });
 
   it("should clear error when sign-in is attempted again", async () => {
-    // First, trigger an error
+    // Throw an error to start
     mockSignInWithProvider.mockRejectedValueOnce(new mockFirebaseUIError("First error"));
 
-    const { fixture } = await render(TestOAuthButtonHostComponent, {
+    await render(TestOAuthButtonHostComponent, {
       imports: [OAuthButtonComponent],
     });
 
     const button = screen.getByRole("button");
 
-    // First click - should show error
     fireEvent.click(button);
     await waitFor(() => {
       expect(screen.getByText("First error")).toBeInTheDocument();
     });
 
-    // Second click - should clear error and attempt again
+    // Remove the error
     mockSignInWithProvider.mockResolvedValueOnce(undefined);
     fireEvent.click(button);
 
diff --git a/packages/angular/src/lib/auth/oauth/twitter-sign-in-button.spec.ts b/packages/angular/src/lib/auth/oauth/twitter-sign-in-button.spec.ts
@@ -19,8 +19,6 @@ import { Component } from "@angular/core";
 
 import { TwitterSignInButtonComponent } from "./twitter-sign-in-button";
 
-// Mocks are handled by jest.config.ts moduleNameMapper and test-helpers.ts
-
 @Component({
   template: `<fui-twitter-sign-in-button></fui-twitter-sign-in-button>`,
   standalone: true,
diff --git a/packages/angular/src/lib/auth/screens/oauth-screen.spec.ts b/packages/angular/src/lib/auth/screens/oauth-screen.spec.ts
@@ -277,7 +277,6 @@ describe("<fui-oauth-screen>", () => {
       });
     });
 
-    // Override the real component with our mock
     TestBed.overrideComponent(MultiFactorAuthAssertionFormComponent, {
       set: {
         template: '<div data-testid="mfa-assertion-form">MFA Assertion Form</div>',
@@ -311,7 +310,6 @@ describe("<fui-oauth-screen>", () => {
       });
     });
 
-    // Override the real component with our mock
     TestBed.overrideComponent(MultiFactorAuthAssertionFormComponent, {
       set: {
         template: '<div data-testid="mfa-assertion-form">MFA Assertion Form</div>',
diff --git a/packages/angular/src/lib/auth/screens/phone-auth-screen.spec.ts b/packages/angular/src/lib/auth/screens/phone-auth-screen.spec.ts
diff --git a/packages/angular/src/lib/auth/screens/sign-in-auth-screen.spec.ts b/packages/angular/src/lib/auth/screens/sign-in-auth-screen.spec.ts
diff --git a/packages/angular/src/lib/auth/screens/sign-up-auth-screen.spec.ts b/packages/angular/src/lib/auth/screens/sign-up-auth-screen.spec.ts
diff --git a/packages/angular/src/lib/components/form.spec.ts b/packages/angular/src/lib/components/form.spec.ts
diff --git a/packages/angular/src/lib/components/policies.spec.ts b/packages/angular/src/lib/components/policies.spec.ts
diff --git a/packages/angular/src/lib/components/redirect-error.spec.ts b/packages/angular/src/lib/components/redirect-error.spec.ts
