fix other tests

Author: ptiurin

src/firebolt/async_db/connection.py

@@ -230,9 +230,15 @@ async def _execute_query(self, request: Request) -> Response:
             return await self._execute_query_impl(request)
 
     async def commit(self) -> None:
-        await self.cursor().execute("COMMIT")
+        if self.closed:
+            raise ConnectionClosedError("Unable to commit: Connection closed.")
+        # Commit is a no-op for V1
+        if not self.cursor_type == CursorV1:
+            await self.cursor().execute("COMMIT")
 
     async def rollback(self) -> None:
+        if self.closed:
+            raise ConnectionClosedError("Unable to rollback: Connection closed.")
         await self.cursor().execute("ROLLBACK")
 
     # Context manager support

src/firebolt/db/connection.py

@@ -311,9 +311,15 @@ def _execute_query(self, request: Request) -> Response:
             return self._execute_query_impl(request)
 
     def commit(self) -> None:
-        self.cursor().execute("COMMIT")
+        if self.closed:
+            raise ConnectionClosedError("Unable to commit: Connection closed.")
+        # Commit is a no-op for V1
+        if not self.cursor_type == CursorV1:
+            self.cursor().execute("COMMIT")
 
     def rollback(self) -> None:
+        if self.closed:
+            raise ConnectionClosedError("Unable to rollback: Connection closed.")
         self.cursor().execute("ROLLBACK")
 
     # Server-side async methods

tests/unit/V1/async_db/test_connection.py

@@ -279,11 +279,11 @@ async def test_connect_default_engine(
 
 async def test_connection_commit(connection: Connection):
     # nothing happens
-    connection.commit()
+    await connection.commit()
 
     await connection.aclose()
     with raises(ConnectionClosedError):
-        connection.commit()
+        await connection.commit()
 
 
 @mark.nofakefs

tests/unit/common/test_base_cursor.py

@@ -3,12 +3,12 @@
 
 from pytest import fixture, mark
 
-from firebolt.common.cursor.base_cursor import (
-    BaseCursor,
+from firebolt.common.cursor.base_cursor import BaseCursor
+from firebolt.common.statement_formatter import create_statement_formatter
+from firebolt.utils.util import (
     _parse_remove_parameters,
     _parse_update_parameters,
 )
-from firebolt.common.statement_formatter import create_statement_formatter
 
 
 @fixture