fix: Fir 27986 engine parameters formatting (#342)

Author: stepansergeevitch

src/firebolt/service/V2/engine.py

@@ -115,6 +115,20 @@ def get_many(
             ]
             return [Engine._from_dict(_dict, self) for _dict in dicts]
 
+    @staticmethod
+    def _format_engine_parameter(
+        value: Union[str, int, EngineType, InstanceType, WarmupMethod]
+    ) -> Union[str, int]:
+        if not isinstance(
+            value, (str, int, EngineType, InstanceType, WarmupMethod)
+        ) or isinstance(value, bool):
+            raise TypeError(f"Unsupported type {type(value)} for engine parameter. ")
+        if isinstance(value, InstanceType):
+            return value.name
+        if isinstance(value, (EngineType, WarmupMethod)):
+            return str(value.value)
+        return value
+
     def create(
         self,
         name: str,
@@ -169,7 +183,7 @@ def create(
             ):
                 if value is not None:
                     sql += f"{param} = ? "
-                    parameters.append(str(value))
+                    parameters.append(self._format_engine_parameter(value))
         with self._connection.cursor() as c:
             c.execute(sql, parameters)
         return self.get(name)

tests/integration/resource_manager/V2/test_engine.py

@@ -1,10 +1,13 @@
 from collections import namedtuple
 
+from pytest import mark
+
 from firebolt.client.auth import Auth
 from firebolt.service.manager import ResourceManager
 from firebolt.service.V2.types import EngineStatus, EngineType, WarmupMethod
 
 
+@mark.slow
 def test_create_start_stop_engine(
     auth: Auth,
     account_name: str,
@@ -16,7 +19,17 @@ def test_create_start_stop_engine(
     )
     name = start_stop_engine_name
 
-    engine = rm.engines.create(name=name)
+    spec = rm.instance_types.get("B1")
+
+    engine = rm.engines.create(
+        name=name,
+        region="us-east-1",
+        engine_type=EngineType.DATA_ANALYTICS,
+        spec=spec,
+        scale=1,
+        auto_stop=120,
+        warmup=WarmupMethod.MINIMAL,
+    )
     assert engine.name == name
 
     database = rm.databases.create(name=name)

tests/unit/service/V2/test_engine.py

@@ -1,5 +1,6 @@
 from typing import Callable
 
+from httpx import Request
 from pytest import raises
 from pytest_httpx import HTTPXMock
 
@@ -11,6 +12,7 @@
     EngineNotFoundError,
     NoAttachedDatabaseError,
 )
+from tests.unit.response import Response
 from tests.unit.service.V2.conftest import get_objects_from_db_callback
 
 
@@ -19,13 +21,24 @@ def test_engine_create(
     resource_manager: ResourceManager,
     instance_type_callback: Callable,
     instance_type_url: str,
-    get_engine_callback: Callable,
     mock_engine: Engine,
     system_engine_no_db_query_url: str,
 ):
+    def create_engine_callback(request: Request) -> Response:
+        if request.content.startswith(b"CREATE"):
+            assert (
+                request.content.decode("utf-8")
+                == "CREATE ENGINE engine_1 WITH REGION = 'us-east-1' ENGINE_TYPE = 'GENERAL_PURPOSE'"
+                " SPEC = 'B1' SCALE = 2 AUTO_STOP = 7200 WARMUP = 'MINIMAL'"
+            )
+        return get_objects_from_db_callback([mock_engine])(request)
 
     httpx_mock.add_callback(instance_type_callback, url=instance_type_url)
-    httpx_mock.add_callback(get_engine_callback, url=system_engine_no_db_query_url)
+    httpx_mock.add_callback(create_engine_callback, url=system_engine_no_db_query_url)
+
+    for value in (1.0, False, int):
+        with raises(TypeError):
+            resource_manager.engines.create("wrong", scale=value)
 
     engine = resource_manager.engines.create(
         name=mock_engine.name,