Skip to content

Commit 71d69cb

Browse files
authored
test: Skip delete tests (#67)
1 parent 2af4f73 commit 71d69cb

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tests/integration/test_sqlalchemy_async_integration.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ async def test_data_write(self, async_connection: Connection, fact_table_name: s
4444
f"UPDATE {fact_table_name} SET dummy='some_other_text' WHERE idx=1"
4545
)
4646
)
47-
# Delete not supported
48-
with pytest.raises(OperationalError):
49-
await async_connection.execute(
50-
text(f"DELETE FROM {fact_table_name} WHERE idx=1")
51-
)
47+
# Delete works but is not officially supported yet
48+
# with pytest.raises(OperationalError):
49+
# await async_connection.execute(
50+
# text(f"DELETE FROM {fact_table_name} WHERE idx=1")
51+
# )
5252

5353
@pytest.mark.asyncio
5454
async def test_set_params(self, async_connection: Engine):

tests/integration/test_sqlalchemy_integration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ def test_data_write(self, connection: Connection, fact_table_name: str):
4747
connection.execute(
4848
f"UPDATE {fact_table_name} SET dummy='some_other_text' WHERE idx=1"
4949
)
50-
# Delete not supported
51-
with pytest.raises(OperationalError):
52-
connection.execute(f"DELETE FROM {fact_table_name} WHERE idx=1")
50+
# Delete works but is not officially supported yet
51+
# with pytest.raises(OperationalError):
52+
# connection.execute(f"DELETE FROM {fact_table_name} WHERE idx=1")
5353

5454
def test_firebolt_types(self, connection: Connection):
5555
result = connection.execute("SELECT '1896-01-01' :: DATE_EXT")

0 commit comments

Comments
 (0)