fix: standardize cel env for change mapping (#1477)

Author: adityathebe

api/v1/zz_generated.deepcopy.go

@@ -57,13 +57,13 @@ spec:
         changes:
           mapping:
             - filter: >
-                change.change_type == 'diff' && change.summary == "status.containerStatuses" && 
+                change_type == 'diff' && summary == "status.containerStatuses" && 
                 patch != null && has(patch.status) && has(patch.status.containerStatuses) && 
                 patch.status.containerStatuses.size() > 0 &&
                 has(patch.status.containerStatuses[0].restartCount)
               type: PodCrashLooping
             - filter: >
-                change.change_type == 'diff' &&
+                change_type == 'diff' &&
                 jq('.status.conditions[]? | select(.type == "Healthy").message', patch).contains('Health check passed')
               type: HealthCheckPassed
           exclude:

fixtures/kubernetes.yaml

@@ -7,11 +7,11 @@ spec:
   changes:
     mapping:
       - filter: >
-          change.change_type == 'diff' && change.summary == "status.containerStatuses" &&
+          change_type == 'diff' && summary == "status.containerStatuses" &&
           patch != null && has(patch.status) && has(patch.status.containerStatuses) &&
           patch.status.containerStatuses.size() > 0 &&
           has(patch.status.containerStatuses[0].restartCount)
         type: PodCrashLooping
       - filter: >
-          change.change_type == 'diff' && change.summary == "status.images" && config.kind == "Node"
+          change_type == 'diff' && summary == "status.images" && config.kind == "Node"
         type: ImageUpdated

fixtures/plugin-change-mapping.yaml

@@ -40,10 +40,12 @@ func (t *changeRule) match(result *v1.ScrapeResult) (bool, error) {
 }
 
 func (t *changeRule) process(ctx api.ScrapeContext, change *v1.ChangeResult) error {
-	env := map[string]any{
-		"change": change.AsMap(),
-		"patch":  change.PatchesMap(),
-	}
+	env := change.AsMap()
+
+	// Deprecated: For backwards compatibility
+	change.FlushMap() // To prevent recursion
+	env["change"] = change.AsMap()
+	env["patch"] = change.PatchesMap()
 
 	ok, err := gomplate.RunTemplateBool(env, gomplate.Template{Expression: t.Rule})
 	if err != nil {

scrapers/changes/rules.go

@@ -15,6 +15,17 @@ var _ = Describe("TestProcessRules", Ordered, func() {
 		rules  []v1.ChangeMapping
 		err    bool
 	}{
+		{
+			name: "config_type in celenv",
+			input: v1.ScrapeResult{
+				Changes: []v1.ChangeResult{{ChangeType: "diff", Patches: "", ConfigType: "HelmRelease"}},
+			},
+			expect: []v1.ChangeResult{{ChangeType: "diff", Patches: "", ConfigType: "HelmRelease"}},
+			rules: []v1.ChangeMapping{{
+				Type:   "diff",
+				Filter: `config_type == 'HelmRelease'`,
+			}},
+		},
 		{
 			name: "health mapping - fail",
 			input: v1.ScrapeResult{
@@ -102,6 +113,10 @@ var _ = Describe("TestProcessRules", Ordered, func() {
 	}
 
 	for _, tt := range tests {
+		// if tt.name != "config_type in celenv" {
+		// 	continue
+		// }
+
 		It(tt.name, func() {
 			err := ProcessRules(api.NewScrapeContext(DefaultContext), &tt.input, tt.rules...)
 			if tt.err {