fix: filtering by external created by

adityathebe · moshloop · commit 53129bbfdc95 · 2024-06-19T10:06:29.000+03:00
diff --git a/query/config_changes.go b/query/config_changes.go
@@ -333,7 +333,11 @@ func FindCatalogChanges(ctx context.Context, req CatalogChangesSearchRequest) (*
 	}
 
 	if req.externalCreatedBy != "" {
-		clauses = append(clauses, clause.Eq{Column: clause.Column{Name: "external_created_by"}, Value: req.externalCreatedBy})
+		clause, err := parseAndBuildFilteringQuery(req.externalCreatedBy, "external_created_by", true)
+		if err != nil {
+			return nil, api.Errorf(api.EINVALID, fmt.Sprintf("failed to parse external createdby: %v", err))
+		}
+		clauses = append(clauses, clause...)
 	}
 
 	table := query.Table("catalog_changes")

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,11 @@ func FindCatalogChanges(ctx context.Context, req CatalogChangesSearchRequest) (*`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`if req.externalCreatedBy != "" {`
`336`		`- clauses = append(clauses, clause.Eq{Column: clause.Column{Name: "external_created_by"}, Value: req.externalCreatedBy})`
	`336`	`+ clause, err := parseAndBuildFilteringQuery(req.externalCreatedBy, "external_created_by", true)`
	`337`	`+ if err != nil {`
	`338`	`+ return nil, api.Errorf(api.EINVALID, fmt.Sprintf("failed to parse external createdby: %v", err))`
	`339`	`+ }`
	`340`	`+ clauses = append(clauses, clause...)`
`337`	`341`	`}`
`338`	`342`
`339`	`343`	`table := query.Table("catalog_changes")`