change utcnow to now(datetime.UTC)

Author: aknopper

flask_monitoringdashboard/core/database_pruning.py

@@ -23,7 +23,7 @@
 def prune_database_older_than_weeks(weeks_to_keep, delete_custom_graph_data):
     """Prune the database of Request and optionally CustomGraph data older than the specified number of weeks"""
     with session_scope() as session:
-        date_to_delete_from = datetime.utcnow() - timedelta(weeks=weeks_to_keep)
+        date_to_delete_from = datetime.now(datetime.timezone.utc) - timedelta(weeks=weeks_to_keep)
 
         # Prune Request table and related Outlier entries
         requests_to_delete = (

flask_monitoringdashboard/database/__init__.py

@@ -72,7 +72,7 @@ class TelemetryUser(Base):
     times_initialized = Column(Integer, default=1)
     """For checking the amount of times the app was initialized"""
 
-    last_initialized = Column(DateTime, default=datetime.datetime.utcnow)
+    last_initialized = Column(DateTime, default=datetime.datetime.now(datetime.UTC))
     """Check when was the last time user accessed FMD"""
 
     monitoring_consent = Column(Integer, default=1)
@@ -93,7 +93,7 @@ class Endpoint(Base):
     monitor_level = Column(Integer, default=config.monitor_level)
     """0 - disabled, 1 - performance, 2 - outliers, 3 - profiler + outliers"""
 
-    time_added = Column(DateTime, default=datetime.datetime.utcnow)
+    time_added = Column(DateTime, default=datetime.datetime.now(datetime.UTC))
     """Time when the endpoint was added."""
 
     version_added = Column(String(100), default=config.version)
@@ -118,7 +118,7 @@ class Request(Base):
     duration = Column(Float, nullable=False)
     """Processing time of the request in milliseconds."""
 
-    time_requested = Column(DateTime, default=datetime.datetime.utcnow)
+    time_requested = Column(DateTime, default=datetime.datetime.now(datetime.UTC))
     """Moment when the request was handled."""
 
     version_requested = Column(String(100), default=config.version)
@@ -225,7 +225,7 @@ class CustomGraph(Base):
     title = Column(String(250), nullable=False, unique=True)
     """Title of this graph."""
 
-    time_added = Column(DateTime, default=datetime.datetime.utcnow)
+    time_added = Column(DateTime, default=datetime.datetime.now(datetime.UTC))
     """When the graph was first added to the dashboard."""
 
     version_added = Column(String(100), default=config.version)
@@ -244,7 +244,7 @@ class CustomGraphData(Base):
     graph = relationship(CustomGraph, backref="data")
     """Graph for which the data is collected."""
 
-    time = Column(DateTime, default=datetime.datetime.utcnow)
+    time = Column(DateTime, default=datetime.datetime.now(datetime.UTC))
     """Moment when the data is collected."""
 
     value = Column(Float)

tests/api/test_custom.py

@@ -17,7 +17,7 @@ def test_custom_graphs(dashboard_user, custom_graph, session):
 
 
 def test_custom_graph_data(dashboard_user, custom_graph, custom_graph_data):
-    today = datetime.utcnow()
+    today = datetime.now(datetime.UTC)
     yesterday = today - timedelta(days=1)
     response = dashboard_user.get('dashboard/api/custom_graph/{id}/{start}/{end}'.format(
         id=custom_graph.graph_id,

tests/api/test_reporting.py

@@ -11,10 +11,10 @@ def test_make_report_get(dashboard_user):
     assert not response.is_json
 
 
-@pytest.mark.parametrize('request_1__time_requested', [datetime.utcnow() - timedelta(hours=6)])
+@pytest.mark.parametrize('request_1__time_requested', [datetime.now(datetime.UTC) - timedelta(hours=6)])
 @pytest.mark.parametrize('request_1__duration', [5000])
 @pytest.mark.parametrize('request_1__status_code', [500])
-@pytest.mark.parametrize('request_2__time_requested', [datetime.utcnow() - timedelta(days=1, hours=6)])
+@pytest.mark.parametrize('request_2__time_requested', [datetime.now(datetime.UTC) - timedelta(days=1, hours=6)])
 @pytest.mark.parametrize('request_2__duration', [100])
 @pytest.mark.skipif(sys.version_info < (3, ), reason="For some reason, this doesn't work in python 2.7.")
 def test_make_report_post_not_significant(dashboard_user, endpoint, request_1, request_2, session):
@@ -23,12 +23,12 @@ def test_make_report_post_not_significant(dashboard_user, endpoint, request_1, r
         'dashboard/api/reporting/make_report/intervals',
         json={
             'interval': {
-                'from': (datetime.utcnow() - timedelta(days=1) - epoch).total_seconds(),
-                'to': (datetime.utcnow() - epoch).total_seconds(),
+                'from': (datetime.now(datetime.UTC) - timedelta(days=1) - epoch).total_seconds(),
+                'to': (datetime.now(datetime.UTC) - epoch).total_seconds(),
             },
             'baseline_interval': {
-                'from': (datetime.utcnow() - timedelta(days=2) - epoch).total_seconds(),
-                'to': (datetime.utcnow() - timedelta(days=1) - epoch).total_seconds(),
+                'from': (datetime.now(datetime.UTC) - timedelta(days=2) - epoch).total_seconds(),
+                'to': (datetime.now(datetime.UTC) - timedelta(days=1) - epoch).total_seconds(),
             },
         },
     )

tests/fixtures/models.py

@@ -58,9 +58,9 @@ class Meta:
 
     name = factory.LazyFunction(lambda: str(uuid.uuid4()))
     monitor_level = 1
-    time_added = factory.LazyFunction(lambda: datetime.utcnow() - timedelta(days=1))
+    time_added = factory.LazyFunction(lambda: datetime.now(datetime.UTC) - timedelta(days=1))
     version_added = "1.0"
-    last_requested = factory.LazyFunction(datetime.utcnow)
+    last_requested = factory.LazyFunction(datetime.now(datetime.UTC))
 
 
 class RequestFactory(ModelFactory):
@@ -69,7 +69,7 @@ class Meta:
 
     endpoint = factory.SubFactory(EndpointFactory)
     duration = factory.LazyFunction(lambda: random() * 5000)
-    time_requested = factory.LazyFunction(datetime.utcnow)
+    time_requested = factory.LazyFunction(datetime.now(datetime.UTC))
     version_requested = factory.LazyFunction(lambda: str(uuid.uuid4()))
     group_by = None
     ip = factory.Faker("ipv4_private")
@@ -115,7 +115,7 @@ class Meta:
         model = CustomGraph
 
     title = factory.Faker("name")
-    time_added = factory.LazyFunction(datetime.utcnow)
+    time_added = factory.LazyFunction(datetime.now(datetime.UTC))
     version_added = factory.LazyFunction(lambda: str(uuid.uuid4()))
 
 
@@ -124,7 +124,7 @@ class Meta:
         model = CustomGraphData
 
     graph = factory.SubFactory(CustomGraphFactory)
-    time = factory.LazyFunction(datetime.utcnow)
+    time = factory.LazyFunction(datetime.now(datetime.UTC))
     value = factory.LazyFunction(random)
 
 

tests/unit/database/test_request.py

@@ -18,7 +18,7 @@
 
 
 def test_get_latencies_sample(session, request_1, endpoint):
-    interval = DateInterval(datetime.utcnow() - timedelta(days=1), datetime.utcnow())
+    interval = DateInterval(datetime.now(datetime.UTC) - timedelta(days=1), datetime.now(datetime.UTC))
     requests_criterion = create_time_based_sample_criterion(interval.start_date(),
                                                             interval.end_date())
     data = get_latencies_sample(session, endpoint.id, requests_criterion, sample_size=500)