-
Notifications
You must be signed in to change notification settings - Fork 14
added Autograd25WaveguideCrossing.ipynb #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
added Autograd25WaveguideCrossing.ipynb #413
Conversation
f6f2b1c to
c0908ae
Compare
|
Spell check passed successfully for 1 notebook(s). |
c0908ae to
9fa0120
Compare
|
resolved spelling mistake |
yaugenst-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mahlau-flex this looks great overall! Just a few notes:
- Could you add this to the notebook index here
- The initial learning rate of 1 seems really high and you can also see the objective function dipping in the first iteration due to that. Have you tried with a lower learning rate?
- I think we should more prominently cite the paper that the parametrization is from at the top.
|
@tomflexcompute @FilipeFcp could one of you have a look too? |
9fa0120 to
02527ad
Compare
|
@yaugenst-flex I have incorporated your previous comments into the notebooks |
|
Thanks @mahlau-flex, this is a very nice example, very didactic! I have just a few comments:
Very small nitpicks:
On a separate note, @yaugenst-flex, can we remove these notes from the other ID notebooks? “Note: native autograd support is an experimental feature in tidy3d 2.7. To see the original implementation of this notebook using jax and the adjoint plugin, refer to this notebook.” |
02527ad to
6cafda2
Compare
|
@FilipeFcp thanks for the feedback! I have incorporated your points into the notebook |
6cafda2 to
9c5db65
Compare
Added a notebook showcasing the new smoothed projection (see paper here: https://arxiv.org/pdf/2503.20189). This method is exempified with a waveguide crossing.