Skip to content

Conversation

@tomflexcompute
Copy link
Contributor

  • Added vertical grating coupler notebook and associated images

  • Edited the metadata on the 2x2 MMI notebook and the plasmonic coupler notebook.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

Spell Check Report

MMIPowerSplitter2x2.ipynb:

Cell 1, Line 3: 'AI-generated'
  > **Note: this notebook is 90% AI-generated.**

SiliconToPlasmonicCoupler.ipynb:

Cell 1, Line 3: 'dielectric-to-plasmonic'
  > This notebook explores the design and simulation of a dielectric-to-plasmonic waveguide coupler using Tidy3D. Such couplers enable efficient transfer of optical signals from conventional silicon photonic waveguides to plasmonic waveguides, which support highly confined modes beyond the diffraction limit.

VerticalGratingCoupler.ipynb:

Cell 10, Line 3: 'expensive-to-evaluate'
  > Bayesian optimization is a powerful strategy for optimizing expensive-to-evaluate functions, using a probabilistic model to efficiently explore the parameter space and identify optimal solutions with fewer simulations.

Checked 3 notebook(s). Found spelling errors in 3 file(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/19934291559

Copy link
Contributor

@alec-flexcompute alec-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting results from the AI: A couple things

For the MMI Power Splitter:

  • Run all cells in order

  • I don't think we need the note about divergence above cell 1

  • The second paragraph above cell 1 says the same thing as the section above cell 3. Since the latter is more detailed, maybe nix the former?

  • The "Key Design Parameters" bullets are kind of superfluous, maybe we could get rid of them

  • In the cell above cell 5, the top comment isn't accurate

  • The periods after every comment, including sentence fragments are a weird result of the AI

  • Great results and analysis!

For the waveguide coupler:

  • Above cell 10, maybe spell out "UCB" in case the user isn't familiar

  • I can tell this simulation wasn't AI generated, because that's all the notes I have haha

For the grating coupler:

  • In the into, the "T." in the citation isn't highlighted

  • This is a great notebook, with useful visualization in diagrams and plotting!

@FilipeFcp
Copy link
Contributor

Hi Tom.

The vertical grating coupler is a great example! I just have two really minor comments to nitpick:

• In the second code block, use a capital D in the first comment for consistency: # define → # Define
• In the fifth code block: # Gratingsize → # Grating size

Sorry, these are all tiny details, but the notebook is great. That’s all I found xd

- Added vertical grating coupler notebook and associated images

- Edited the metadata on the 2x2 MMI notebook and the plasmonic coupler notebook.
@tomflexcompute tomflexcompute force-pushed the tom/vertical_grating_coupler branch from ed7d33f to 12f7c07 Compare December 4, 2025 15:28
@tomflexcompute tomflexcompute merged commit c5a2fd0 into develop Dec 4, 2025
1 check passed
@tomflexcompute tomflexcompute deleted the tom/vertical_grating_coupler branch December 4, 2025 15:28
@alec-flexcompute
Copy link
Contributor

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants