started adding "swap_axes" to "plot_field()", and all of the functions it depends on. WARNING: This effort is not complete. The code is now in a completely broken state. But I had to backup my changes before I changed branches.

Author: jewettaijfc

tests/test_components/test_geometry.py

@@ -204,11 +204,11 @@ def test_array_to_vertices():
     assert np.all(np.array(vertices) == np.array(vertices2))
 
 
-@pytest.mark.parametrize("component", GEO_TYPES)
-def test_intersections_plane(component):
-    assert len(component.intersections_plane(z=0.2)) > 0
-    assert len(component.intersections_plane(x=0.2)) > 0
-    assert len(component.intersections_plane(x=10000)) == 0
+@pytest.mark.parametrize("component, swap_axes", zip(GEO_TYPES, [True, False]))
+def test_intersections_plane(component, swap_axes):
+    assert len(component.intersections_plane(z=0.2, swap_axes=swap_axes)) > 0
+    assert len(component.intersections_plane(x=0.2, swap_axes=swap_axes)) > 0
+    assert len(component.intersections_plane(x=10000, swap_axes=swap_axes)) == 0
 
 
 def test_intersections_plane_inf():

tidy3d/components/data/sim_data.py

@@ -16,6 +16,7 @@
 from tidy3d.components.autograd.utils import split_list
 from tidy3d.components.base import JSON_TAG, Tidy3dBaseModel
 from tidy3d.components.base_sim.data.sim_data import AbstractSimulationData
+from tidy3d.components.geometry.base import Geometry
 from tidy3d.components.file_util import replace_values
 from tidy3d.components.monitor import Monitor
 from tidy3d.components.simulation import Simulation
@@ -452,6 +453,7 @@ def plot_field_monitor_data(
         vmax: Optional[float] = None,
         ax: Ax = None,
         shading: str = "flat",
+        swap_axes: bool = False,
         **sel_kwargs,
     ) -> Ax:
         """Plot the field data for a monitor with simulation plot overlaid.
@@ -651,6 +653,7 @@ def plot_field_monitor_data(
             ax=ax,
             shading=shading,
             infer_intervals=True if shading == "flat" else False,
+            swap_axes=swap_axes,
         )
 
     def plot_field(
@@ -666,6 +669,7 @@ def plot_field(
         vmax: Optional[float] = None,
         ax: Ax = None,
         shading: str = "flat",
+        swap_axes: bool = False,
         **sel_kwargs,
     ) -> Ax:
         """Plot the field data for a monitor with simulation plot overlaid.
@@ -730,6 +734,7 @@ def plot_field(
             vmax=vmax,
             ax=ax,
             shading=shading,
+            swap_axes=swap_axes,
             **sel_kwargs,
         )
 
@@ -747,6 +752,7 @@ def plot_scalar_array(
         vmax: Optional[float] = None,
         cmap_type: ColormapType = "divergent",
         ax: Ax = None,
+        swap_axes: bool = False,
         **kwargs,
     ) -> Ax:
         """Plot the field data for a monitor with simulation plot overlaid.
@@ -807,10 +813,16 @@ def plot_scalar_array(
             eps_reverse = False
 
         # plot the field
-        xy_coord_labels = list("xyz")
-        xy_coord_labels.pop(axis)
+        xy_coord_labels = Geometry.pop_axis_and_swap("xyz", axis=axis, swap_axes=swap_axes)
         x_coord_label, y_coord_label = xy_coord_labels[0], xy_coord_labels[1]
-        field_data.plot(
+
+        field_data_tmp = field_data.copy()
+        if swap_axes:
+            # field_data.coords is a 2-column matrix of 2D coordinate data
+            assert len(field_data.coords.shape) == 2 and field_data.coords.shape[1] == 2
+            # swap column 0 (x coords) with column 1 (y coords)
+            field_data_tmp.coords = field_data_tmp.coords[:, ::-1]
+        field_data_tmp.plot(
             ax=ax,
             x=x_coord_label,
             y=y_coord_label,
@@ -819,7 +831,7 @@ def plot_scalar_array(
             vmax=vmax,
             robust=robust,
             center=center,
-            cbar_kwargs={"label": field_data.name},
+            cbar_kwargs={"label": field_data_tmp.name},
             **kwargs,
         )
 
@@ -830,12 +842,13 @@ def plot_scalar_array(
             alpha=eps_alpha,
             reverse=eps_reverse,
             ax=ax,
+            swap_axes=swap_axes,
             **interp_kwarg,
         )
 
         # set the limits based on the xarray coordinates min and max
-        x_coord_values = field_data.coords[x_coord_label]
-        y_coord_values = field_data.coords[y_coord_label]
+        x_coord_values = field_data_tmp.coords[x_coord_label]
+        y_coord_values = field_data_tmp.coords[y_coord_label]
         ax.set_xlim(min(x_coord_values), max(x_coord_values))
         ax.set_ylim(min(y_coord_values), max(y_coord_values))
 

tidy3d/components/mode/mode_solver.py

@@ -2029,6 +2029,7 @@ def plot_field(
         vmin: Optional[float] = None,
         vmax: Optional[float] = None,
         ax: Ax = None,
+        swap_axes: bool = False,
         **sel_kwargs,
     ) -> Ax:
         """Plot the field for a :class:`.ModeSolverData` with :class:`.Simulation` plot overlaid.
@@ -2080,12 +2081,14 @@ def plot_field(
             vmin=vmin,
             vmax=vmax,
             ax=ax,
+            swap_axes=swap_axes,
             **sel_kwargs,
         )
 
     def plot(
         self,
         ax: Ax = None,
+        swap_axes: bool = False,
         **patch_kwargs,
     ) -> Ax:
         """Plot the mode plane simulation's components.
@@ -2122,6 +2125,7 @@ def plot(
             monitor_alpha=0,
             lumped_element_alpha=0,
             ax=ax,
+            swap_axes=swap_axes,
             **patch_kwargs,
         )
 
@@ -2132,6 +2136,7 @@ def plot_eps(
         freq: Optional[float] = None,
         alpha: Optional[float] = None,
         ax: Ax = None,
+        swap_axes: bool = False,
     ) -> Ax:
         """Plot the mode plane simulation's components.
         The permittivity is plotted in grayscale based on its value at the specified frequency.
@@ -2179,6 +2184,7 @@ def plot_eps(
             monitor_alpha=0,
             lumped_element_alpha=0,
             ax=ax,
+            swap_axes=swap_axes,
         )
 
     def plot_structures_eps(
@@ -2188,6 +2194,7 @@ def plot_structures_eps(
         cbar: bool = True,
         reverse: bool = False,
         ax: Ax = None,
+        swap_axes: bool = False,
     ) -> Ax:
         """Plot the mode plane simulation's components.
         The permittivity is plotted in grayscale based on its value at the specified frequency.
@@ -2239,11 +2246,13 @@ def plot_structures_eps(
             hlim=h_lim,
             vlim=v_lim,
             ax=ax,
+            swap_axes=swap_axes,
         )
 
     def plot_grid(
         self,
         ax: Ax = None,
+        swap_axes: bool = False,
         **kwargs,
     ) -> Ax:
         """Plot the mode plane cell boundaries as lines.
@@ -2269,7 +2278,7 @@ def plot_grid(
         )
 
         return self.simulation.plot_grid(
-            x=a_center[0], y=a_center[1], z=a_center[2], hlim=h_lim, vlim=v_lim, ax=ax, **kwargs
+            x=a_center[0], y=a_center[1], z=a_center[2], hlim=h_lim, vlim=v_lim, ax=ax, swap_axes=swap_axes, **kwargs
         )
 
     @classmethod
@@ -2363,6 +2372,7 @@ def _mode_plane_size_no_pml(
     def plot_pml(
         self,
         ax: Ax = None,
+        swap_axes: bool = False,
     ) -> Ax:
         """Plot the mode plane absorbing boundaries.
 
@@ -2377,16 +2387,16 @@ def plot_pml(
             The supplied or created matplotlib axes.
         """
         return self._plot_pml(
-            simulation=self.simulation, plane=self.plane, mode_spec=self.mode_spec, ax=ax
+            simulation=self.simulation, plane=self.plane, mode_spec=self.mode_spec, ax=ax, swap_axes=swap_axes
         )
 
     @classmethod
     def _plot_pml(
-        cls, simulation: Simulation, plane: Box, mode_spec: ModeSpec, ax: Ax = None
+        cls, simulation: Simulation, plane: Box, mode_spec: ModeSpec, ax: Ax = None, swap_axes: bool = False,
     ) -> Ax:
         """Plot the mode plane absorbing boundaries."""
         # Get the mode plane normal axis, center, and limits.
-        _, h_lim, v_lim, _ = cls._center_and_lims(simulation=simulation, plane=plane)
+        _, h_lim, v_lim, _ = cls._center_and_lims(simulation=simulation, plane=plane, swap_axes=swap_axes)
 
         # Create ax if ax=None.
         if not ax:
@@ -2434,16 +2444,20 @@ def _plot_pml(
         return ax
 
     @staticmethod
-    def _center_and_lims(simulation: Simulation, plane: Box) -> tuple[list, list, list, list]:
+    def _center_and_lims(
+        simulation: Simulation,
+        plane: Box,
+        swap_axes: bool = False
+    ) -> tuple[list, list, list, list]:
         """Get the mode plane center and limits."""
         normal_axis = plane.size.index(0.0)
 
-        n_axis, t_axes = plane.pop_axis([0, 1, 2], normal_axis)
+        n_axis, t_axes = plane.pop_axis_and_swap([0, 1, 2], normal_axis, swap_axes=swap_axes)
         a_center = [None, None, None]
         a_center[n_axis] = plane.center[n_axis]
 
-        _, (h_min_s, v_min_s) = Box.pop_axis(simulation.bounds[0], axis=n_axis)
-        _, (h_max_s, v_max_s) = Box.pop_axis(simulation.bounds[1], axis=n_axis)
+        _, (h_min_s, v_min_s) = Box.pop_axis_and_swap(simulation.bounds[0], axis=n_axis, swap_axes=swap_axes)
+        _, (h_max_s, v_max_s) = Box.pop_axis_and_swap(simulation.bounds[1], axis=n_axis, swap_axes=swap_axes)
 
         h_min = plane.center[t_axes[0]] - plane.size[t_axes[0]] / 2
         h_max = plane.center[t_axes[0]] + plane.size[t_axes[0]] / 2