-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Labels
Bugsomething isnt workingsomething isnt working
Description
These tests have been broken for years.
Should we delete them?
Several modules that the tests/_test_local/ tests depend on have been removed.
tests/_test_local/_test_adjoint_performance.py
tries toimport tidy3d_backend
tests/_test_local/_test_data_performance.py
tries toimport tidy3d_backend
tests/_test_local/_test_fit_web.py
tries toimport tidy3d.plugins.fitter
tests/_test_local/_test_plugins_web.py
tries toimport tidy3d.plugins.fitter
tests/_test_local/_test_web.py
tries toimport tidy3d.web.auth
These three modules (eg. tidy3d_backend
, tidy3d.plugins.fitter
, tidy3d.web.auth
) no longer exist, and the functions they contained (eg. encode_password
, get_credentials
) are also missing from the codebase.
To Reproduce
pytest tests/_test_local/*.py
UPDATE: The missing modules contained code that is very out of date, which is probably why they were removed.
Priority
Low. This is not a user-facing bug. But these tests might be useful to have.
Additional context
I was hoping to use these tests to verify that PR2654 is working.
(It's probably not a big problem for me at the moment. I will try adding my changes to test_webapi.py instead.)
Metadata
Metadata
Assignees
Labels
Bugsomething isnt workingsomething isnt working