Merge pull request #59 from samcragg/master

Check for no SymbolInfo for variables

Author: Meir017

src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs

@@ -91,6 +91,22 @@ public static void Main() { }
             DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
         }
 
+        [TestMethod]
+        [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/58")]
+        public void StaticWithNameof_ShouldNotThrow()
+        {
+            const string source = @"public class TestClass
+{
+    private static string StaticResult { get; set; }
+
+    public static void Main()
+    {
+        StaticResult = nameof(Main);
+    }
+}";
+            DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
+        }
+
         [TestMethod]
         [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/49")]
         public void WritingToConsole_ShouldNotThrow()

src/FluentAssertions.Analyzers/Utilities/VariableNameExtractor.cs

@@ -53,11 +53,17 @@ public static string ExtractVariabeName(InvocationExpressionSyntax invocation)
 
         private bool IsVariable(IdentifierNameSyntax node)
         {
-            // TODO: cleanup
-            if (_semanticModel == null) return true;
+            if (_semanticModel != null)
+            {
+                SymbolInfo info = _semanticModel.GetSymbolInfo(node);
+                if (info.Symbol == null ||
+                    info.Symbol.Kind == SymbolKind.Method ||
+                    info.Symbol.IsStatic)
+                {
+                    return false;
+                }
+            }
 
-            var info = _semanticModel.GetSymbolInfo(node);
-            if (info.Symbol.Kind == SymbolKind.Method || info.Symbol.IsStatic) return false;
             return true;
         }
     }